Re: RFR: 8307194: Enhance static-libs-image [v2]

2023-05-03 Thread Jiangli Zhou
On Wed, 3 May 2023 18:31:56 GMT, Erik Joelsson wrote: >> Jiangli Zhou has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update based on @erikj79 review comments and suggestions: >> - Change to copy libjvm.a for $(JVM_VARIANT_MAIN) only i

Re: RFR: 8307194: Enhance static-libs-image [v2]

2023-05-03 Thread Severin Gehwolf
On Wed, 3 May 2023 18:40:52 GMT, Jiangli Zhou wrote: >> I'm hoping to get input from the graal team on the impact of this change. >> The exact usage of the new libjvm.a file is still under discussion so I >> share you concern about changing things for the current static libs usecase >> before

Re: RFR: 8307194: Enhance static-libs-image [v2]

2023-05-03 Thread Jiangli Zhou
On Wed, 3 May 2023 18:33:56 GMT, Erik Joelsson wrote: >> make/Main.gmk line 1060: >> >>> 1058: symbols-image: $(LIBS_TARGETS) $(LAUNCHER_TARGETS) >>> 1059: >>> 1060: static-libs-image: hotspot-static-libs $(STATIC_LIBS_TARGETS) >> >> Could we decouple `hotspot-static-libs` from `static-lib

Re: RFR: 8307194: Enhance static-libs-image [v2]

2023-05-03 Thread Erik Joelsson
On Wed, 3 May 2023 17:05:29 GMT, Severin Gehwolf wrote: >> Jiangli Zhou has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update based on @erikj79 review comments and suggestions: >> - Change to copy libjvm.a for $(JVM_VARIANT_MAIN) only

Re: RFR: 8307194: Enhance static-libs-image [v2]

2023-05-03 Thread Erik Joelsson
On Wed, 3 May 2023 17:58:25 GMT, Jiangli Zhou wrote: >> This PR is branched from the makefile changes for >> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for >> handling the JDK/VM static libraries: >> >> - Create libjvm.a together with other JDK static libraries when

Re: RFR: 8307194: Enhance static-libs-image [v2]

2023-05-03 Thread Jiangli Zhou
On Wed, 3 May 2023 13:42:03 GMT, Erik Joelsson wrote: >> Jiangli Zhou has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update based on @erikj79 review comments and suggestions: >> - Change to copy libjvm.a for $(JVM_VARIANT_MAIN) only i

Re: RFR: 8307194: Enhance static-libs-image [v2]

2023-05-03 Thread Jiangli Zhou
> This PR is branched from the makefile changes for > https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for > handling the JDK/VM static libraries: > > - Create libjvm.a together with other JDK static libraries when building > 'static-libs-image' (or 'static-libs-bundles')