On Thu, 4 May 2023 19:32:45 GMT, Jiangli Zhou wrote:
>>> [...] I'll see if I can test this on a mandrel build tomorrow...
>>
>> @jianglizhou So I've tested this with a mandrel build and it doesn't break
>> terribly, but a graalvm build after this patch has *two* `libjvm.a` which a)
>> doesn't
On Thu, 4 May 2023 19:12:14 GMT, Severin Gehwolf wrote:
>> As @jerboaa mentioned, for GraalVM native-image we produce our own
>> `libjvm.a` as part of building GraalVM (every native image gets statically
>> linked to that library). See
>> https://github.com/oracle/graal/blob/f1c1d710625ac84559
On Thu, 4 May 2023 19:12:14 GMT, Severin Gehwolf wrote:
>> As @jerboaa mentioned, for GraalVM native-image we produce our own
>> `libjvm.a` as part of building GraalVM (every native image gets statically
>> linked to that library). See
>> https://github.com/oracle/graal/blob/f1c1d710625ac84559
On Thu, 4 May 2023 09:40:31 GMT, Paul Woegerer wrote:
>> GraalVM native-image has it's own `libjvm.a` shim which would likely
>> conflict or produce undesirable results. So I'd prefer the approach where
>> `static-libs-image` wouldn't produce hotspot `libjvm.a` as part of it. For
>> new uses-c
On Wed, 3 May 2023 18:51:54 GMT, Severin Gehwolf wrote:
>>> Could we decouple `hotspot-static-libs` from `static-libs-image` somehow,
>>> please? `static-libs-image` is used by the `graal-builder-image` target and
>>> it would be good if it didn't include hotspot static libs as they are not
>>
On Wed, 3 May 2023 18:51:54 GMT, Severin Gehwolf wrote:
>>> Could we decouple `hotspot-static-libs` from `static-libs-image` somehow,
>>> please? `static-libs-image` is used by the `graal-builder-image` target and
>>> it would be good if it didn't include hotspot static libs as they are not
>>
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/VM static libraries:
>
> - Create libjvm.a together with other JDK static libraries when building
> 'static-libs-image' (or 'static-libs-bundles')