Re: RFR: 8307652: sealed class hierarchy graph doesn't distinguish non-sealed classes [v2]

2023-05-24 Thread Jonathan Gibbons
On Tue, 16 May 2023 17:16:57 GMT, Chen Liang wrote: >> `@sealedGraph` had a mechanism to render non-sealed classes differently, but >> it's useless because the graph nodes are not bordered. This patch converts >> the non-sealed classes to be rendered in italics instead. >> >> An example of

Re: RFR: 8307652: sealed class hierarchy graph doesn't distinguish non-sealed classes [v2]

2023-05-23 Thread -
Hi, Jonathan Gibbons, would you mind taking a look at this and approve if this looks good? I wish to get this into JDK 21 before RDP 1 starts. On Mon, May 22, 2023 at 2:25 AM Per Minborg wrote: > > On Tue, 16 May 2023 17:16:57 GMT, Chen Liang wrote: > > >> `@sealedGraph` had a mechanism to

Re: RFR: 8307652: sealed class hierarchy graph doesn't distinguish non-sealed classes [v2]

2023-05-22 Thread Per Minborg
On Tue, 16 May 2023 17:16:57 GMT, Chen Liang wrote: >> `@sealedGraph` had a mechanism to render non-sealed classes differently, but >> it's useless because the graph nodes are not bordered. This patch converts >> the non-sealed classes to be rendered in italics instead. >> >> An example of

Re: RFR: 8307652: sealed class hierarchy graph doesn't distinguish non-sealed classes [v2]

2023-05-17 Thread Per Minborg
On Tue, 16 May 2023 17:16:57 GMT, Chen Liang wrote: >> `@sealedGraph` had a mechanism to render non-sealed classes differently, but >> it's useless because the graph nodes are not bordered. This patch converts >> the non-sealed classes to be rendered in italics instead. >> >> An example of

Re: RFR: 8307652: sealed class hierarchy graph doesn't distinguish non-sealed classes [v2]

2023-05-16 Thread Chen Liang
> `@sealedGraph` had a mechanism to render non-sealed classes differently, but > it's useless because the graph nodes are not bordered. This patch converts > the non-sealed classes to be rendered in italics instead. > > An example of `ConstantDesc`, which has a sealed hierarchy except >