Re: RFR: 8307732: build-test-lib is broken

2023-05-10 Thread Daniel Jeliński
On Tue, 9 May 2023 10:38:54 GMT, Johannes Bechberger wrote: > Fixes the issue by adding `--add-exports` for the required modules and making > the `HttpHeaderParser` final (fixing an issue with calling overridable > methods in a constructor). Just making sure everyone had a chance to take a lo

Re: RFR: 8307732: build-test-lib is broken

2023-05-10 Thread Johannes Bechberger
On Tue, 9 May 2023 10:38:54 GMT, Johannes Bechberger wrote: > Fixes the issue by adding `--add-exports` for the required modules and making > the `HttpHeaderParser` final (fixing an issue with calling overridable > methods in a constructor). What is preventing this PR from being merged? The C

Re: RFR: 8307732: build-test-lib is broken

2023-05-09 Thread Daniel Jeliński
On Tue, 9 May 2023 10:38:54 GMT, Johannes Bechberger wrote: > Fixes the issue by adding `--add-exports` for the required modules and making > the `HttpHeaderParser` final (fixing an issue with calling overridable > methods in a constructor). Marked as reviewed by djelinski (Reviewer). --

Re: RFR: 8307732: build-test-lib is broken

2023-05-09 Thread Erik Joelsson
On Tue, 9 May 2023 10:38:54 GMT, Johannes Bechberger wrote: > Fixes the issue by adding `--add-exports` for the required modules and making > the `HttpHeaderParser` final (fixing an issue with calling overridable > methods in a constructor). Marked as reviewed by erikj (Reviewer). --

Re: RFR: 8307732: build-test-lib is broken

2023-05-09 Thread Johannes Bechberger
On Tue, 9 May 2023 10:38:54 GMT, Johannes Bechberger wrote: > Fixes the issue by adding `--add-exports` for the required modules and making > the `HttpHeaderParser` final (fixing an issue with calling overridable > methods in a constructor). Well, I wanted to use the WhiteBox testing API for

Re: RFR: 8307732: build-test-lib is broken

2023-05-09 Thread Daniel Jeliński
On Tue, 9 May 2023 10:38:54 GMT, Johannes Bechberger wrote: > Fixes the issue by adding `--add-exports` for the required modules and making > the `HttpHeaderParser` final (fixing an issue with calling overridable > methods in a constructor). That's interesting. How did you find this? Is the r

RFR: 8307732: build-test-lib is broken

2023-05-09 Thread Johannes Bechberger
Fixes the issue by adding `--add-exports` for the required modules and making the `HttpHeaderParser` final (fixing an issue with calling overridable methods in a constructor). - Commit messages: - Fix make build-test-lib Changes: https://git.openjdk.org/jdk/pull/13885/files Webre