Re: RFR: 8308753: Class-File API transition to Preview [v32]

2023-12-01 Thread Adam Sotona
On Wed, 29 Nov 2023 08:46:46 GMT, Per Minborg wrote: >> This is explicit list of supported class file versions, so I don't see any >> other way. > > Would it not be possible to expose an immutable `Map` that > maps from Java version to major class version? This is actually out of scope of

Re: RFR: 8308753: Class-File API transition to Preview [v32]

2023-11-29 Thread Per Minborg
On Tue, 28 Nov 2023 13:03:48 GMT, Adam Sotona wrote: >> src/java.base/share/classes/java/lang/classfile/ClassFile.java line 1404: >> >>> (failed to retrieve contents of file, check the PR for context) >> Is there a more scalable way to express the major class version? The current >> approach

Re: RFR: 8308753: Class-File API transition to Preview [v32]

2023-11-28 Thread Adam Sotona
On Tue, 28 Nov 2023 10:21:25 GMT, Per Minborg wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed SwitchBootstrapTest > > src/java.base/share/classes/java/lang/classfile/ClassFile.java line 1404: > >> (failed to

Re: RFR: 8308753: Class-File API transition to Preview [v32]

2023-11-28 Thread Per Minborg
On Mon, 27 Nov 2023 10:01:50 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK

Re: RFR: 8308753: Class-File API transition to Preview [v32]

2023-11-27 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR