On Thu, 3 Aug 2023 20:53:56 GMT, Matias Saavedra Silva
wrote:
>> The recent change in
>> [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more
>> -Wconversion warnings that are addressed in this patch. The aforementioned
>> change has overlooked inconsistencies with the types
On Thu, 3 Aug 2023 19:15:30 GMT, Coleen Phillimore wrote:
>> As far as I've designed it, only the last two bits of the flags are ever set
>> or used. C++ booleans are either 0 or 1 so the higher bits should never be
>> set.
>
> It is only two bits and the only variable here "is_final_shift" is
On Thu, 3 Aug 2023 20:53:56 GMT, Matias Saavedra Silva
wrote:
>> The recent change in
>> [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more
>> -Wconversion warnings that are addressed in this patch. The aforementioned
>> change has overlooked inconsistencies with the types
> The recent change in
> [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more
> -Wconversion warnings that are addressed in this patch. The aforementioned
> change has overlooked inconsistencies with the types used by
> `ResolvedFieldEntry` and the method `fill_in()`. Verified