Re: RFR: 8314265: Fix -Wconversion warnings in miscellaneous runtime code [v3]

2023-08-16 Thread Coleen Phillimore
On Wed, 16 Aug 2023 18:51:03 GMT, Thomas Stuefe wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert to use static_cast. > > src/hotspot/share/logging/logOutput.cpp line 77: > >> 75: ntags++; >> 76: }

Re: RFR: 8314265: Fix -Wconversion warnings in miscellaneous runtime code [v3]

2023-08-16 Thread Thomas Stuefe
On Wed, 16 Aug 2023 13:48:35 GMT, Coleen Phillimore wrote: >> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion >> warnings in runtime code. This is the last one I'm going to do for runtime >> for a while. >> Tested with tier1-4. > > Coleen Phillimore has updated the pul

Re: RFR: 8314265: Fix -Wconversion warnings in miscellaneous runtime code [v3]

2023-08-16 Thread Johan Sjölen
On Wed, 16 Aug 2023 13:48:35 GMT, Coleen Phillimore wrote: >> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion >> warnings in runtime code. This is the last one I'm going to do for runtime >> for a while. >> Tested with tier1-4. > > Coleen Phillimore has updated the pul

Re: RFR: 8314265: Fix -Wconversion warnings in miscellaneous runtime code [v3]

2023-08-16 Thread Coleen Phillimore
> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion > warnings in runtime code. This is the last one I'm going to do for runtime > for a while. > Tested with tier1-4. Coleen Phillimore has updated the pull request incrementally with one additional commit since the last r

Re: RFR: 8314265: Fix -Wconversion warnings in miscellaneous runtime code [v3]

2023-08-16 Thread Coleen Phillimore
On Wed, 16 Aug 2023 13:01:53 GMT, Christian Hagedorn wrote: >> This code: >> >> uint64_t isa; >> if (!_reader.read_uleb128(&isa, 4)) { >> // isa register is 4 bytes wide. >> return false; >> } >> _state->_isa = isa; // only save 4 bytes >> >> returns 64