Re: RFR: 8314438: NMT: Performance benchmarks are needed to have a baseline for comparison of improvements [v3]

2023-09-26 Thread Afshin Zafari
On Tue, 26 Sep 2023 09:51:32 GMT, Magnus Ihse Bursie wrote: > Should there not be a label to alert NMT folks for reviewing? Thanks for the comment. - PR Comment: https://git.openjdk.org/jdk/pull/15563#issuecomment-1735229316

Re: RFR: 8314438: NMT: Performance benchmarks are needed to have a baseline for comparison of improvements [v3]

2023-09-26 Thread Magnus Ihse Bursie
On Tue, 26 Sep 2023 08:57:43 GMT, Afshin Zafari wrote: >> A new benchmark for measuring the NMT overhead in `summary` and `detail` >> modes. >> The tests are run using: >> >> make CONF=debug test TEST="micro:java.util.NMTBenchmark" >> MICRO="RESULTS_FORMAT=json" >> >> The results are writte

Re: RFR: 8314438: NMT: Performance benchmarks are needed to have a baseline for comparison of improvements [v3]

2023-09-26 Thread Afshin Zafari
> A new benchmark for measuring the NMT overhead in `summary` and `detail` > modes. > The tests are run using: > > make CONF=debug test TEST="micro:java.util.NMTBenchmark" > MICRO="RESULTS_FORMAT=json" > > The results are written to a JSON file that can be visualized using [JMH > Visualizer]

Re: RFR: 8314438: NMT: Performance benchmarks are needed to have a baseline for comparison of improvements [v2]

2023-09-25 Thread Afshin Zafari
On Mon, 25 Sep 2023 07:41:24 GMT, Alan Bateman wrote: >> Afshin Zafari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> new benchmark moved to vm/runtime folder. > > test/micro/org/openjdk/bench/java/util/NMTBenchmark.java line 24: > >>

Re: RFR: 8314438: NMT: Performance benchmarks are needed to have a baseline for comparison of improvements [v2]

2023-09-25 Thread Afshin Zafari
> A new benchmark for measuring the NMT overhead in `summary` and `detail` > modes. > The tests are run using: > > make CONF=debug test TEST="micro:java.util.NMTBenchmark" > MICRO="RESULTS_FORMAT=json" > > The results are written to a JSON file that can be visualized using [JMH > Visualizer]

Re: RFR: 8314438: NMT: Performance benchmarks are needed to have a baseline for comparison of improvements

2023-09-25 Thread Alan Bateman
On Tue, 5 Sep 2023 07:53:36 GMT, Afshin Zafari wrote: > A new benchmark for measuring the NMT overhead in `summary` and `detail` > modes. > The tests are run using: > > make CONF=debug test TEST="micro:java.util.NMTBenchmark" > MICRO="RESULTS_FORMAT=json" > > The results are written to a JS

Re: RFR: 8314438: NMT: Performance benchmarks are needed to have a baseline for comparison of improvements

2023-09-25 Thread Afshin Zafari
On Wed, 6 Sep 2023 19:56:10 GMT, Gerard Ziemski wrote: > The test will not compile for me unless I add: > > `import java.util.concurrent.TimeUnit;` Sorry, it was removed mistakenly before pushing the code. Now fixed. > You said `The JSON file can be used for visualising the results.` Can you

RFR: 8314438: NMT: Performance benchmarks are needed to have a baseline for comparison of improvements

2023-09-25 Thread Afshin Zafari
A new benchmark for measuring the NMT overhead in `summary` and `detail` modes. The tests are run using: make CONF=debug test TEST="micro:java.util.NMTBenchmark" MICRO="RESULTS_FORMAT=json" The results are written to a JSON file that can be visualized using [JMH Visualizer](https://jmh.moreth

Re: RFR: 8314438: NMT: Performance benchmarks are needed to have a baseline for comparison of improvements

2023-09-25 Thread Gerard Ziemski
On Tue, 5 Sep 2023 07:53:36 GMT, Afshin Zafari wrote: > A new benchmark for measuring the NMT overhead in `summary` and `detail` > modes. > The tests are run using: > > make CONF=debug test TEST="micro:java.util.NMTBenchmark" > MICRO="RESULTS_FORMAT=json" > > The results are written to a JS