On Wed, 1 Nov 2023 06:58:23 GMT, David Holmes wrote:
>> I've removed the goto, but would like to wait until Thomas is back
>
> No response from @tstuefe but I think the empty block is pointless and we
> should just check `if (!InterceptOSException) {`.
Sure, remove the empty block.
On Tue, 31 Oct 2023 08:37:44 GMT, Julian Waters wrote:
>> Ick! I hadn't followed https://github.com/openjdk/jdk/pull/15096 closely, so
>> hadn't noticed the discussion there. Not sure why this is using a literal 0
>> rather than `(T) '\n'` as in that PR?
>>
>> So the literal "0" (or
On Wed, 1 Nov 2023 05:54:34 GMT, Julian Waters wrote:
>> Prepare HotSpot for the permissive- Visual C++ flag, this change contains
>> all of the fixes required for HotSpot to compile under the stricter mode
>> activated when the permissive- flag is passed
>>
>> - Reworks code in
On Wed, 4 Oct 2023 04:40:25 GMT, Julian Waters wrote:
>> I think killing the goto makes most sense here.
>
> I've removed the goto, but would like to wait until Thomas is back
No response from @tstuefe but I think the empty block is pointless and we
should just check `if
> Prepare HotSpot for the permissive- Visual C++ flag, this change contains all
> of the fixes required for HotSpot to compile under the stricter mode
> activated when the permissive- flag is passed
>
> - Reworks code in topLevelUnhandledExceptionFilter for os_windows.cpp to
> avoid goto
