Re: RFR: 8318913: The module-infos for --release data do not contain pre-set versions [v2]

2023-11-20 Thread Jan Lahoda
On Fri, 10 Nov 2023 00:42:43 GMT, Magnus Ihse Bursie wrote: > The build changes almost look good. Just remove the extra added lines at the > end. > > I think this point too still remains: > > > 1. TransitiveDependencies seems to be unused now. I assume this is > > intended. But maybe the java

Re: RFR: 8318913: The module-infos for --release data do not contain pre-set versions [v2]

2023-11-09 Thread Magnus Ihse Bursie
On Thu, 9 Nov 2023 14:09:39 GMT, Jan Lahoda wrote: >> Consider a simple module, like: >> >> module test {} >> >> >> And compile it with JDK 22 and JDK 21 using: >> javac --release 21 >> >> The results of the compilations will differ: when compiling with JDK 21, the >> mandated java.base depe

Re: RFR: 8318913: The module-infos for --release data do not contain pre-set versions [v2]

2023-11-09 Thread Magnus Ihse Bursie
On Wed, 8 Nov 2023 16:25:59 GMT, Magnus Ihse Bursie wrote: >> Jan Lahoda has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - Fixing tests. >> - Merge remote-tracking branch 'erikj/pull/16400' into JDK-8318913 >> - Build fixes >> - Incl

Re: RFR: 8318913: The module-infos for --release data do not contain pre-set versions [v2]

2023-11-09 Thread Vicente Romero
On Thu, 9 Nov 2023 14:09:39 GMT, Jan Lahoda wrote: >> Consider a simple module, like: >> >> module test {} >> >> >> And compile it with JDK 22 and JDK 21 using: >> javac --release 21 >> >> The results of the compilations will differ: when compiling with JDK 21, the >> mandated java.base depe

Re: RFR: 8318913: The module-infos for --release data do not contain pre-set versions [v2]

2023-11-09 Thread Jan Lahoda
> Consider a simple module, like: > > module test {} > > > And compile it with JDK 22 and JDK 21 using: > javac --release 21 > > The results of the compilations will differ: when compiling with JDK 21, the > mandated java.base dependency will get a version, possibly like > "21-internal". When