On Tue, 14 Nov 2023 11:04:43 GMT, Aleksey Shipilev wrote:
>> Looking at why GHA did not catch
>> [JDK-8320050](https://bugs.openjdk.org/browse/JDK-8320050), even though it
>> builds hotspot, I realized we do not configure the build with gtest, which
>> means we skip the build checks for gtest
On Tue, 14 Nov 2023 11:04:43 GMT, Aleksey Shipilev wrote:
>> Looking at why GHA did not catch
>> [JDK-8320050](https://bugs.openjdk.org/browse/JDK-8320050), even though it
>> builds hotspot, I realized we do not configure the build with gtest, which
>> means we skip the build checks for gtest
On Tue, 14 Nov 2023 11:04:43 GMT, Aleksey Shipilev wrote:
>> Looking at why GHA did not catch
>> [JDK-8320050](https://bugs.openjdk.org/browse/JDK-8320050), even though it
>> builds hotspot, I realized we do not configure the build with gtest, which
>> means we skip the build checks for gtest
On Tue, 14 Nov 2023 11:04:43 GMT, Aleksey Shipilev wrote:
>> Looking at why GHA did not catch
>> [JDK-8320050](https://bugs.openjdk.org/browse/JDK-8320050), even though it
>> builds hotspot, I realized we do not configure the build with gtest, which
>> means we skip the build checks for gtest
On Tue, 14 Nov 2023 11:04:43 GMT, Aleksey Shipilev wrote:
>> Looking at why GHA did not catch
>> [JDK-8320050](https://bugs.openjdk.org/browse/JDK-8320050), even though it
>> builds hotspot, I realized we do not configure the build with gtest, which
>> means we skip the build checks for gtest
On Tue, 14 Nov 2023 11:04:43 GMT, Aleksey Shipilev wrote:
>> Looking at why GHA did not catch
>> [JDK-8320050](https://bugs.openjdk.org/browse/JDK-8320050), even though it
>> builds hotspot, I realized we do not configure the build with gtest, which
>> means we skip the build checks for gtest
On Tue, 14 Nov 2023 11:07:08 GMT, Magnus Ihse Bursie wrote:
> (If you feel the urge to open a PR before all testing is complete, you can
> mark it as draft to avoid having it being reviewed before it is ready to
> review...)
Yeah, I meant to open as draft to get testing done, but misclicked.
On Tue, 14 Nov 2023 11:04:43 GMT, Aleksey Shipilev wrote:
>> Looking at why GHA did not catch
>> [JDK-8320050](https://bugs.openjdk.org/browse/JDK-8320050), even though it
>> builds hotspot, I realized we do not configure the build with gtest, which
>> means we skip the build checks for gtest
> Looking at why GHA did not catch
> [JDK-8320050](https://bugs.openjdk.org/browse/JDK-8320050), even though it
> builds hotspot, I realized we do not configure the build with gtest, which
> means we skip the build checks for gtest VM. It would be useful to
> cross-compile with all tests
