Re: RFR: 8324937: GHA: Avoid multiple test suites per job

2024-01-31 Thread Christoph Langer
On Tue, 30 Jan 2024 10:34:40 GMT, Aleksey Shipilev wrote: > See the description in the bug. This mitigates the issue by splitting out the > only test job that has two test suites in it. Marked as reviewed by clanger (Reviewer). - PR Review:

Re: RFR: 8324937: GHA: Avoid multiple test suites per job

2024-01-31 Thread Aleksey Shipilev
On Tue, 30 Jan 2024 19:05:02 GMT, Magnus Ihse Bursie wrote: >> See the description in the bug. This mitigates the issue by splitting out >> the only test job that has two test suites in it. > > I think this combination of two tests were made due to fear of too much > overhead of creating a

Re: RFR: 8324937: GHA: Avoid multiple test suites per job

2024-01-30 Thread Aleksey Shipilev
On Tue, 30 Jan 2024 19:05:02 GMT, Magnus Ihse Bursie wrote: > or was it just a premature optimization that is causing us headache now? This one. When I did this originally, I thought why have another job when we can stash some groups together? But the cost for additional job is not actually

Re: RFR: 8324937: GHA: Avoid multiple test suites per job

2024-01-30 Thread Magnus Ihse Bursie
On Tue, 30 Jan 2024 10:34:40 GMT, Aleksey Shipilev wrote: > See the description in the bug. This mitigates the issue by splitting out the > only test job that has two test suites in it. I think this combination of two tests were made due to fear of too much overhead of creating a small test

Re: RFR: 8324937: GHA: Avoid multiple test suites per job

2024-01-30 Thread Erik Joelsson
On Tue, 30 Jan 2024 10:34:40 GMT, Aleksey Shipilev wrote: > See the description in the bug. This mitigates the issue by splitting out the > only test job that has two test suites in it. Marked as reviewed by erikj (Reviewer). - PR Review:

RFR: 8324937: GHA: Avoid multiple test suites per job

2024-01-30 Thread Aleksey Shipilev
See the description in the bug. This mitigates the issue by splitting out the only test job that has two test suites in it. - Commit messages: - Revert test breakage and touchups - Break the tier1_compiler test and see what happens - Fix Changes: