Re: RFR: 8325878: Require minimum Clang version 13

2024-03-06 Thread Kim Barrett
On Thu, 15 Feb 2024 05:19:45 GMT, Kim Barrett wrote: > Please review this change that updates the minimum supported version of Clang > to be used for building OpenJDK from 3.5 to 13. > > This permits enabling C++17 (JDK-8314488), though Clang 5 might suffice for > that. A minimum of Clang 13

Re: RFR: 8325878: Require minimum Clang version 13 [v2]

2024-03-06 Thread Kim Barrett
> Please review this change that updates the minimum supported version of Clang > to be used for building OpenJDK from 3.5 to 13. > > This permits enabling C++17 (JDK-8314488), though Clang 5 might suffice for > that. A minimum of Clang 13 also obtains a critical bug fix for the > [[noreturn]] >

Re: RFR: 8325878: Require minimum Clang version 13

2024-03-06 Thread Magnus Ihse Bursie
On Tue, 5 Mar 2024 08:24:20 GMT, Kim Barrett wrote: > I don't want to integrate this until the minimum aix-ppc toolchain has been > updated @kimbarrett Is anyone working on that problem? - PR Comment: https://git.openjdk.org/jdk/pull/17862#issuecomment-1981399543

Re: RFR: 8325878: Require minimum Clang version 13

2024-03-05 Thread Kim Barrett
On Tue, 5 Mar 2024 07:20:33 GMT, Kim Barrett wrote: > Thanks for reviews/responses. I'll go ahead with integration. We won't be > reliant on the new version immediately, so we can still reconsider if it > causes someone problems and they bring it up soon-ish. Well, no I'm not. I don't want

Re: RFR: 8325878: Require minimum Clang version 13

2024-03-04 Thread Kim Barrett
On Thu, 15 Feb 2024 05:19:45 GMT, Kim Barrett wrote: > Please review this change that updates the minimum supported version of Clang > to be used for building OpenJDK from 3.5 to 13. > > This permits enabling C++17 (JDK-8314488), though Clang 5 might suffice for > that. A minimum of Clang 13

Re: RFR: 8325878: Require minimum Clang version 13

2024-02-27 Thread Kim Barrett
On Thu, 15 Feb 2024 05:19:45 GMT, Kim Barrett wrote: > Please review this change that updates the minimum supported version of Clang > to be used for building OpenJDK from 3.5 to 13. > > This permits enabling C++17 (JDK-8314488), though Clang 5 might suffice for > that. A minimum of Clang 13

Re: RFR: 8325878: Require minimum Clang version 13

2024-02-15 Thread Thomas Stuefe
On Fri, 16 Feb 2024 04:46:24 GMT, Kim Barrett wrote: > > Unfortunately this will break my workflow on Linux - I use clang to build > > on Ubuntu 20.04, which is not that old, but it ships with clang 12. This is > > not a deal breaker, just annoying. > > That's unfortunate, but I think the

Re: RFR: 8325878: Require minimum Clang version 13

2024-02-15 Thread Kim Barrett
On Thu, 15 Feb 2024 12:45:45 GMT, Thomas Stuefe wrote: > Unfortunately this will break my workflow on Linux - I use clang to build on > Ubuntu 20.04, which is not that old, but it ships with clang 12. This is not > a deal breaker, just annoying. That's unfortunate, but I think the

Re: RFR: 8325878: Require minimum Clang version 13

2024-02-15 Thread Thomas Stuefe
On Thu, 15 Feb 2024 05:19:45 GMT, Kim Barrett wrote: > Please review this change that updates the minimum supported version of Clang > to be used for building OpenJDK from 3.5 to 13. > > This permits enabling C++17 (JDK-8314488), though Clang 5 might suffice for > that. A minimum of Clang 13

Re: RFR: 8325878: Require minimum Clang version 13

2024-02-15 Thread Magnus Ihse Bursie
On Thu, 15 Feb 2024 05:19:45 GMT, Kim Barrett wrote: > Please review this change that updates the minimum supported version of Clang > to be used for building OpenJDK from 3.5 to 13. > > This permits enabling C++17 (JDK-8314488), though Clang 5 might suffice for > that. A minimum of Clang 13

Re: RFR: 8325878: Require minimum Clang version 13

2024-02-15 Thread Julian Waters
On Thu, 15 Feb 2024 05:19:45 GMT, Kim Barrett wrote: > Please review this change that updates the minimum supported version of Clang > to be used for building OpenJDK from 3.5 to 13. > > This permits enabling C++17 (JDK-8314488), though Clang 5 might suffice for > that. A minimum of Clang 13

RFR: 8325878: Require minimum Clang version 13

2024-02-14 Thread Kim Barrett
Please review this change that updates the minimum supported version of Clang to be used for building OpenJDK from 3.5 to 13. This permits enabling C++17 (JDK-8314488), though Clang 5 might suffice for that. A minimum of Clang 13 also obtains a critical bug fix for the [[noreturn]] attribute (see