Re: RFR: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 [v3]

2024-02-26 Thread Magnus Ihse Bursie
On Mon, 26 Feb 2024 08:55:04 GMT, Andrew Haley wrote: >> I assume you want to know if we use DAS/DAS1 for debugging purposes on that >> platform? > > I use `das` every day. In contrast, I don't know what `das1` is for. It does not sound like anyone object to the removal of `JNIEXPORT` for

Re: RFR: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 [v3]

2024-02-26 Thread Andrew Haley
On Sat, 24 Feb 2024 20:01:50 GMT, Martijn Verburg wrote: >> Hi all - yes the Windows Arm port is maintained by Microsoft's JDK team. How >> can we help in this particular case? > > I assume you want to know if we use DAS/DAS1 for debugging purposes on that > platform? I use `das` every day.

Re: RFR: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 [v3]

2024-02-24 Thread Martijn Verburg
On Sat, 24 Feb 2024 20:00:34 GMT, Martijn Verburg wrote: >> Personally I have never used `das`/`das1` on any AArch64 port when >> debugging. I guess it was somewhat handy when the backend was originally >> developed. I would argue that the built-in disassembler of any debugger and >>

Re: RFR: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 [v3]

2024-02-24 Thread Martijn Verburg
On Fri, 23 Feb 2024 12:03:37 GMT, Bernhard Urban-Forster wrote: >> Instead of discussing removal of windows/aarch64 (although the general rule >> in OpenJDK is that ports that are not maintained by anyone should be >> removed); let's stick to the question here: do we need to export `das1()`

Re: RFR: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 [v3]

2024-02-23 Thread Magnus Ihse Bursie
> Once [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234) has been > integrated, it is possible to do some cleanup. The goal of > [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234) was to not change > any behavior, even if that behavior seemed odd. > > Now let's try to fix