On Tue, 27 Feb 2024 11:06:15 GMT, Magnus Ihse Bursie wrote:
>> This was actually an important part of this PR, trying to combat the all too
>> general solution we had when trying to combine microsoft and non-microsoft
>> linking. On all Unix-style linkers, the option to mark the output file is
On Tue, 27 Feb 2024 11:04:49 GMT, Magnus Ihse Bursie wrote:
>> I tend to agree, this should not have been changed to specifying -o
>> directly. We generally keep options inside Makefile variables rather than
>> directly passing them like this, much like how $(OBJ_SUFFIX) was recently
>> used
On Tue, 27 Feb 2024 05:20:11 GMT, Julian Waters wrote:
>> make/common/native/Link.gmk line 131:
>>
>>> 129:$(if $$($1_LINK_OBJS_RELATIVE), $$(CD) $$(OUTPUTDIR) ; ) \
>>> 130: $$($1_LD) $(LDFLAGS_CXX_PARTIAL_LINKING)
>>> $$($1_SYSROOT_LDFLAGS) \
>>> 131:
On Tue, 27 Feb 2024 01:30:17 GMT, Jiangli Zhou wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix indentation
>
> make/common/native/Link.gmk line 131:
>
>> 129: $(if $$($1_LINK_OBJS_RELATIVE),
On Mon, 26 Feb 2024 11:03:19 GMT, Magnus Ihse Bursie wrote:
>> There is not much overlap on how linking is done on Windows on one hand, and
>> on all Unix platforms on the other. This makes Link.gmk basically consists
>> of two parts, each in it own half of if statements, and the few common
On Mon, 26 Feb 2024 11:03:19 GMT, Magnus Ihse Bursie wrote:
>> There is not much overlap on how linking is done on Windows on one hand, and
>> on all Unix platforms on the other. This makes Link.gmk basically consists
>> of two parts, each in it own half of if statements, and the few common
> There is not much overlap on how linking is done on Windows on one hand, and
> on all Unix platforms on the other. This makes Link.gmk basically consists of
> two parts, each in it own half of if statements, and the few common parts are
> artificially shoehorned in to fit both sides.
>
> The
