On Tue, 27 Feb 2024 13:55:53 GMT, Ludvig Janiuk wrote:
> Clarifying text in `make help` output on how to list variables for e.g.
> JTREG='...'.
Marked as reviewed by ihse (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18028#pullrequestreview-1917514719
On Tue, 27 Feb 2024 13:55:53 GMT, Ludvig Janiuk wrote:
> Clarifying text in `make help` output on how to list variables for e.g.
> JTREG='...'.
> I have no idea what causes it.
Nevermind. The patch looks good.
-
Marked as reviewed by gli (Committer).
PR Review:
On Tue, 27 Feb 2024 13:55:53 GMT, Ludvig Janiuk wrote:
> Clarifying text in `make help` output on how to list variables for e.g.
> JTREG='...'.
It's interesting that the order of those two lines can change. I have no idea
what causes it.
-
PR Comment:
On Tue, 27 Feb 2024 13:55:53 GMT, Ludvig Janiuk wrote:
> Clarifying text in `make help` output on how to list variables for e.g.
> JTREG='...'.
I use the command `make test-only JTREG=help` locally, the outputed message
seems an error (shown below). Does it work as expected?
Building target
On Tue, 27 Feb 2024 13:55:53 GMT, Ludvig Janiuk wrote:
> Clarifying text in `make help` output on how to list variables for e.g.
> JTREG='...'.
Thanks for the insight Erik!
-
PR Comment: https://git.openjdk.org/jdk/pull/18028#issuecomment-1968538692
On Tue, 27 Feb 2024 13:56:56 GMT, Ludvig Janiuk wrote:
> I'll note that you still need to run configure to execute make test-only
> JTREG=help. Should this really be necessary?
I agree that it would be convenient, in some rare usecase, to be able to run
this without configure, but the added
On Tue, 27 Feb 2024 13:55:53 GMT, Ludvig Janiuk wrote:
> Clarifying text in `make help` output on how to list variables for e.g.
> JTREG='...'.
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18028#pullrequestreview-1904771315
Clarifying text in `make help` output on how to list variables for e.g.
JTREG='...'.
-
Commit messages:
- 8326831 Clarify test harness control variables in make help
Changes: https://git.openjdk.org/jdk/pull/18028/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18028=00
On Tue, 27 Feb 2024 13:55:53 GMT, Ludvig Janiuk wrote:
> Clarifying text in `make help` output on how to list variables for e.g.
> JTREG='...'.
I'll note that you still need to run configure to execute `make test-only
JTREG=help`. Should this really be necessary?
Also, while `make test-only
