On Tue, 5 Mar 2024 18:16:51 GMT, Vladimir Kozlov wrote:
>> Kim Barrett has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commi
> Please review this change to update the HotSpot Style Guide's discussion of
> nullptr and its use.
>
> I suggest this is an editorial rather than substantive change to the style
> guide. As such, the normal HotSpot PR process can be used for this change.
Kim Barrett has updated the pull reques
On Tue, 5 Mar 2024 07:12:09 GMT, Kim Barrett wrote:
>> Please review this change to update the HotSpot Style Guide's discussion of
>> nullptr and its use.
>>
>> I suggest this is an editorial rather than substantive change to the style
>> guide. As such, the normal HotSpot PR process can be use
On Tue, 5 Mar 2024 07:12:09 GMT, Kim Barrett wrote:
>> Please review this change to update the HotSpot Style Guide's discussion of
>> nullptr and its use.
>>
>> I suggest this is an editorial rather than substantive change to the style
>> guide. As such, the normal HotSpot PR process can be use
On Tue, 5 Mar 2024 07:12:09 GMT, Kim Barrett wrote:
>> Please review this change to update the HotSpot Style Guide's discussion of
>> nullptr and its use.
>>
>> I suggest this is an editorial rather than substantive change to the style
>> guide. As such, the normal HotSpot PR process can be use
On Tue, 5 Mar 2024 07:12:09 GMT, Kim Barrett wrote:
>> Please review this change to update the HotSpot Style Guide's discussion of
>> nullptr and its use.
>>
>> I suggest this is an editorial rather than substantive change to the style
>> guide. As such, the normal HotSpot PR process can be use
On Mon, 4 Mar 2024 09:52:15 GMT, Aleksey Shipilev wrote:
>> Kim Barrett has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> respond to shipilev comments
>
> doc/hotspot-style.md line 738:
>
>> 736: expressions with value zero. C++14 replac
On Mon, 4 Mar 2024 18:01:35 GMT, Vladimir Kozlov wrote:
>> I think it would be enough to write 1..2 sentences about this, and then
>> defer to N2431 already linked here for more details.
>
> I agree with Aleksey.
Good point. I decided just referring to the paper for rationale is sufficient.
-
> Please review this change to update the HotSpot Style Guide's discussion of
> nullptr and its use.
>
> I suggest this is an editorial rather than substantive change to the style
> guide. As such, the normal HotSpot PR process can be used for this change.
Kim Barrett has updated the pull reques
On Mon, 4 Mar 2024 09:51:16 GMT, Aleksey Shipilev wrote:
>> doc/hotspot-style.md line 730:
>>
>>> 728: Use `nullptr`
>>> 729:
>>> ([n2431](http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2431.pdf))
>>> 730: rather than `NULL`. Don't use (constant expression or literal) 0 for
>>> poin
On Mon, 4 Mar 2024 08:38:09 GMT, Kim Barrett wrote:
> Please review this change to update the HotSpot Style Guide's discussion of
> nullptr and its use.
>
> I suggest this is an editorial rather than substantive change to the style
> guide. As such, the normal HotSpot PR process can be used for
On Mon, 4 Mar 2024 08:41:46 GMT, Kim Barrett wrote:
>> Please review this change to update the HotSpot Style Guide's discussion of
>> nullptr and its use.
>>
>> I suggest this is an editorial rather than substantive change to the style
>> guide. As such, the normal HotSpot PR process can be use
Please review this change to update the HotSpot Style Guide's discussion of
nullptr and its use.
I suggest this is an editorial rather than substantive change to the style
guide. As such, the normal HotSpot PR process can be used for this change.
-
Commit messages:
- update nullptr
On Mon, 4 Mar 2024 08:38:09 GMT, Kim Barrett wrote:
> Please review this change to update the HotSpot Style Guide's discussion of
> nullptr and its use.
>
> I suggest this is an editorial rather than substantive change to the style
> guide. As such, the normal HotSpot PR process can be used for
14 matches
Mail list logo