Re: RFR: 8327675: jspawnhelper should be built on all unix platforms

2024-03-08 Thread Magnus Ihse Bursie
On Fri, 8 Mar 2024 13:58:25 GMT, Erik Joelsson wrote: > Looks good, but why are the tests failing? **macos-x64 / test (langtools/tier1)** fails when installing homebrew: Error: Failure while executing; `/usr/bin/env /usr/local/Homebrew/Library/Homebrew/shims/shared/curl --disable --cookie

Re: RFR: 8327675: jspawnhelper should be built on all unix platforms

2024-03-08 Thread Erik Joelsson
On Fri, 8 Mar 2024 10:17:08 GMT, Magnus Ihse Bursie wrote: > We should match the building of jspawnhelper in > make/modules/java.base/Launcher.gmk with the usage for all unix platforms in > src/java.base/unix/classes/java/lang/ProcessImpl.java. > > Granted, the list of OSes in the makefile

Re: RFR: 8327675: jspawnhelper should be built on all unix platforms

2024-03-08 Thread Thomas Stuefe
On Fri, 8 Mar 2024 10:17:08 GMT, Magnus Ihse Bursie wrote: > We should match the building of jspawnhelper in > make/modules/java.base/Launcher.gmk with the usage for all unix platforms in > src/java.base/unix/classes/java/lang/ProcessImpl.java. > > Granted, the list of OSes in the makefile

Re: RFR: 8327675: jspawnhelper should be built on all unix platforms

2024-03-08 Thread Aleksey Shipilev
On Fri, 8 Mar 2024 10:17:08 GMT, Magnus Ihse Bursie wrote: > We should match the building of jspawnhelper in > make/modules/java.base/Launcher.gmk with the usage for all unix platforms in > src/java.base/unix/classes/java/lang/ProcessImpl.java. > > Granted, the list of OSes in the makefile

RFR: 8327675: jspawnhelper should be built on all unix platforms

2024-03-08 Thread Magnus Ihse Bursie
We should match the building of jspawnhelper in make/modules/java.base/Launcher.gmk with the usage for all unix platforms in src/java.base/unix/classes/java/lang/ProcessImpl.java. Granted, the list of OSes in the makefile amounts to the current list of all Unix OSes in the JDK, but there is no