Re: RFR: 8328146: Set LIBCXX automatically [v3]

2024-03-15 Thread Erik Joelsson
On Thu, 14 Mar 2024 14:03:07 GMT, Magnus Ihse Bursie wrote: >> We are adding LIBCXX to LIBS in calls to SetupJdkLibrary whenever LINK_TYPE >> is C++. We should do this automatically in SetupJdkLibrary for C++ linking. >> >> I also removed the superfluous `-lc` from some places where it had

Re: RFR: 8328146: Set LIBCXX automatically [v3]

2024-03-14 Thread Magnus Ihse Bursie
On Thu, 14 Mar 2024 15:56:42 GMT, Erik Joelsson wrote: >> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains four >> additional

Re: RFR: 8328146: Set LIBCXX automatically [v3]

2024-03-14 Thread Magnus Ihse Bursie
On Thu, 14 Mar 2024 15:53:37 GMT, Erik Joelsson wrote: >> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains four >> additional

Re: RFR: 8328146: Set LIBCXX automatically [v3]

2024-03-14 Thread Erik Joelsson
On Thu, 14 Mar 2024 14:03:07 GMT, Magnus Ihse Bursie wrote: >> We are adding LIBCXX to LIBS in calls to SetupJdkLibrary whenever LINK_TYPE >> is C++. We should do this automatically in SetupJdkLibrary for C++ linking. >> >> I also removed the superfluous `-lc` from some places where it had

Re: RFR: 8328146: Set LIBCXX automatically [v3]

2024-03-14 Thread Magnus Ihse Bursie
> We are adding LIBCXX to LIBS in calls to SetupJdkLibrary whenever LINK_TYPE > is C++. We should do this automatically in SetupJdkLibrary for C++ linking. > > I also removed the superfluous `-lc` from some places where it had been added. Magnus Ihse Bursie has updated the pull request with a