On Fri, 15 Mar 2024 12:39:03 GMT, Magnus Ihse Bursie wrote:
>> make/modules/jdk.jpackage/Lib.gmk line 63:
>>
>>> 61: CXXFLAGS_FILTER_OUT := -MD, \
>>> 62: CXXFLAGS := $(JPACKAGE_APPLAUNCHER_INCLUDES), \
>>> 63: CFLAGS := $(JPACKAGE_APPLAUNCHER_INCLUDES), \
>>
>> This removed `-MD`,
On Thu, 14 Mar 2024 19:45:10 GMT, Erik Joelsson wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix syntax error
>
> make/modules/jdk.jpackage/Lib.gmk line 63:
>
>> 61: CXXFLAGS_FILTER_OUT := -MD, \
>>
On Thu, 14 Mar 2024 18:01:34 GMT, Erik Joelsson wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix syntax error
>
> make/common/JdkNativeCompilation.gmk line 206:
>
>> 204: $$(foreach flag,
On Thu, 14 Mar 2024 15:16:53 GMT, Magnus Ihse Bursie wrote:
>> We are setting one of the flags `CFLAGS_JDKLIB`, `CXXFLAGS_JDKLIB`,
>> `CFLAGS_JDKEXE` or `CXXFLAGS_JDKEXE` to `CFLAGS` or `CXXFLAGS`,
>> respectively, in basically all calls to `SetupJdkLibrary` and
>> `SetupJdkExecutable`.
>>
> We are setting one of the flags `CFLAGS_JDKLIB`, `CXXFLAGS_JDKLIB`,
> `CFLAGS_JDKEXE` or `CXXFLAGS_JDKEXE` to `CFLAGS` or `CXXFLAGS`, respectively,
> in basically all calls to `SetupJdkLibrary` and `SetupJdkExecutable`.
>
> These flag variables contain a lot of duplication.
>
> The first
