Re: RFR: 8329471: Remove GTK2 [v5]

2024-08-05 Thread Magnus Ihse Bursie
On Wed, 31 Jul 2024 19:17:05 GMT, Alexander Zvegintsev wrote: >> GTK2 support for Swing/AWT was deprecated for removal in JDK 21. >> >> It's being removed because no platform that supports the JDK needs it. >> >> Manual and automated testing is green. > > Alexander Zvegintsev has updated the

Re: RFR: 8329471: Remove GTK2 [v5]

2024-08-01 Thread Phil Race
On Wed, 31 Jul 2024 19:17:05 GMT, Alexander Zvegintsev wrote: >> GTK2 support for Swing/AWT was deprecated for removal in JDK 21. >> >> It's being removed because no platform that supports the JDK needs it. >> >> Manual and automated testing is green. > > Alexander Zvegintsev has updated the

Re: RFR: 8329471: Remove GTK2 [v5]

2024-07-31 Thread Abhishek Kumar
On Wed, 31 Jul 2024 19:17:05 GMT, Alexander Zvegintsev wrote: >> GTK2 support for Swing/AWT was deprecated for removal in JDK 21. >> >> It's being removed because no platform that supports the JDK needs it. >> >> Manual and automated testing is green. > > Alexander Zvegintsev has updated the

Re: RFR: 8329471: Remove GTK2 [v4]

2024-07-31 Thread Alexander Zvegintsev
On Wed, 31 Jul 2024 18:29:57 GMT, Phil Race wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> more cleanup > > src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKPainter.java > line 215: > >> 213

Re: RFR: 8329471: Remove GTK2 [v5]

2024-07-31 Thread Alexander Zvegintsev
> GTK2 support for Swing/AWT was deprecated for removal in JDK 21. > > It's being removed because no platform that supports the JDK needs it. > > Manual and automated testing is green. Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last rev

Re: RFR: 8329471: Remove GTK2 [v4]

2024-07-31 Thread Phil Race
On Tue, 30 Jul 2024 17:51:06 GMT, Alexander Zvegintsev wrote: >> GTK2 support for Swing/AWT was deprecated for removal in JDK 21. >> >> It's being removed because no platform that supports the JDK needs it. >> >> Manual and automated testing is green. > > Alexander Zvegintsev has updated the

Re: RFR: 8329471: Remove GTK2

2024-07-31 Thread Abhishek Kumar
On Wed, 31 Jul 2024 11:59:39 GMT, Alexander Zvegintsev wrote: > No, it's still a valid test to check if GTK 2 is not loaded, since we don't > want it to be. It doesn't hurt anyway. Yeah, that's true. Although this condition check for GTK2 can be removed as it breaks out of loop and throw RTE

Re: RFR: 8329471: Remove GTK2

2024-07-31 Thread Alexander Zvegintsev
On Wed, 31 Jul 2024 09:31:42 GMT, Abhishek Kumar wrote: > > Other references related to gtk2 here > > > > 1. > > [DesktopGtkLoadTest](https://github.com/openjdk/jdk/blob/574358df3b4891e953f84814c64ac651ea37755a/test/jdk/java/awt/Desktop/DesktopGtkLoadTest/DesktopGtkLoadTest.java#L56) > > Did y

Re: RFR: 8329471: Remove GTK2

2024-07-31 Thread Abhishek Kumar
On Tue, 30 Jul 2024 07:43:22 GMT, Abhishek Kumar wrote: > Other references related to gtk2 here > > 1. > [DesktopGtkLoadTest](https://github.com/openjdk/jdk/blob/574358df3b4891e953f84814c64ac651ea37755a/test/jdk/java/awt/Desktop/DesktopGtkLoadTest/DesktopGtkLoadTest.java#L56) Did you miss to

Re: RFR: 8329471: Remove GTK2 [v4]

2024-07-30 Thread Alexander Zvegintsev
> GTK2 support for Swing/AWT was deprecated for removal in JDK 21. > > It's being removed because no platform that supports the JDK needs it. > > Manual and automated testing is green. Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last rev

Re: RFR: 8329471: Remove GTK2 [v3]

2024-07-30 Thread Alexander Zvegintsev
> GTK2 support for Swing/AWT was deprecated for removal in JDK 21. > > It's being removed because no platform that supports the JDK needs it. > > Manual and automated testing is green. Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last rev

Re: RFR: 8329471: Remove GTK2 [v3]

2024-07-30 Thread Alexander Zvegintsev
On Tue, 30 Jul 2024 07:12:17 GMT, Abhishek Kumar wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> revert spacing > > src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKIconFactory.java > line 1:

Re: RFR: 8329471: Remove GTK2 [v2]

2024-07-30 Thread Alexander Zvegintsev
> GTK2 support for Swing/AWT was deprecated for removal in JDK 21. > > It's being removed because no platform that supports the JDK needs it. > > Manual and automated testing is green. Alexander Zvegintsev has updated the pull request incrementally with three additional commits since the last

Re: RFR: 8329471: Remove GTK2

2024-07-30 Thread Abhishek Kumar
On Mon, 29 Jul 2024 14:55:07 GMT, Alexander Zvegintsev wrote: > GTK2 support for Swing/AWT was deprecated for removal in JDK 21. > > It's being removed because no platform that supports the JDK needs it. > > Manual and automated testing is green. Other references related to gtk2 here 1. [D

Re: RFR: 8329471: Remove GTK2

2024-07-30 Thread Abhishek Kumar
On Mon, 29 Jul 2024 14:55:07 GMT, Alexander Zvegintsev wrote: > GTK2 support for Swing/AWT was deprecated for removal in JDK 21. > > It's being removed because no platform that supports the JDK needs it. > > Manual and automated testing is green. src/java.desktop/share/classes/com/sun/java/s

RFR: 8329471: Remove GTK2

2024-07-29 Thread Alexander Zvegintsev
GTK2 support for Swing/AWT was deprecated for removal in JDK 21. It's being removed because no platform that supports the JDK needs it. Manual and automated testing is green. - Commit messages: - 8329471: Remove GTK2 Changes: https://git.openjdk.org/jdk/pull/20378/files Webrev: