Re: RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected

2024-04-29 Thread SendaoYan
On Fri, 26 Apr 2024 03:32:25 GMT, SendaoYan wrote: > Hi, > > The curl command lack of "-L" option, cause download file fail, the size of > download file is empty. > > curl download fail without `-L`: >```log >> rm -rf jmh-core-1.37.jar ; curl -O --fail >> https://maven.aliyun.com/repo

Re: RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected

2024-04-29 Thread Aleksey Shipilev
On Fri, 26 Apr 2024 03:32:25 GMT, SendaoYan wrote: > Hi, > > The curl command lack of "-L" option, cause download file fail, the size of > download file is empty. > > curl download fail without `-L`: >```log >> rm -rf jmh-core-1.37.jar ; curl -O --fail >> https://maven.aliyun.com/repo

Re: RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected

2024-04-27 Thread SendaoYan
On Sat, 27 Apr 2024 01:15:45 GMT, Jaikiran Pai wrote: >>> Thank you for those details @sendaoYan. >>> >>> Adding `-L` (follow redirects) to unconditionally follow redirects doesn't >>> look right to me. I think, one would want to know, during the build >>> process, if any URLs that are in use

Re: RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected

2024-04-26 Thread Jaikiran Pai
On Fri, 26 Apr 2024 16:23:28 GMT, SendaoYan wrote: >>> Hello @sendaoYan, who is adding the 302 redirect to that jar location and >>> to which location is the URL being redirected to? What does `curl -v -O >>> ` show in the logs (please paste the textual logs instead of an >>> image). >> >> He

Re: RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected

2024-04-26 Thread SendaoYan
On Fri, 26 Apr 2024 09:48:51 GMT, SendaoYan wrote: >> Hello @sendaoYan, who is adding the 302 redirect to that jar location and to >> which location is the URL being redirected to? What does `curl -v -O >> ` show in the logs (please paste the textual logs instead of an >> image). > >> Hello @

Re: RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected

2024-04-26 Thread Erik Joelsson
On Fri, 26 Apr 2024 11:30:24 GMT, Jaikiran Pai wrote: > Adding `-L` (follow redirects) to unconditionally follow redirects doesn't > look right to me. I think, one would want to know, during the build process, > if any URLs that are in use (like this one) have changed their location and > then

Re: RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected

2024-04-26 Thread Erik Joelsson
On Fri, 26 Apr 2024 03:32:25 GMT, SendaoYan wrote: > Hi, > > The curl command lack of "-L" option, cause download file fail, the size of > download file is empty. > > curl download fail without `-L`: >```log >> rm -rf jmh-core-1.37.jar ; curl -O --fail >> https://maven.aliyun.com/repo

Re: RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected

2024-04-26 Thread Jaikiran Pai
On Fri, 26 Apr 2024 09:48:51 GMT, SendaoYan wrote: >> Hello @sendaoYan, who is adding the 302 redirect to that jar location and to >> which location is the URL being redirected to? What does `curl -v -O >> ` show in the logs (please paste the textual logs instead of an >> image). > >> Hello @

Re: RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected

2024-04-26 Thread SendaoYan
On Fri, 26 Apr 2024 08:53:21 GMT, Jaikiran Pai wrote: > Hello @sendaoYan, who is adding the 302 redirect to that jar location and to > which location is the URL being redirected to? What does `curl -v -O > ` show in the logs (please paste the textual logs instead of an > image). Hello @jaikir

Re: RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected

2024-04-26 Thread Jaikiran Pai
On Fri, 26 Apr 2024 03:32:25 GMT, SendaoYan wrote: > Hi, > > The curl command lack of "-L" option, cause download file fail, the size of > download file is empty. > > ![image](https://github.com/openjdk/jdk/assets/24123821/7b5471ae-8e00-4a06-a327-7186c42bd6a6) > > Only change devkit shell

RFR: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected

2024-04-25 Thread SendaoYan
Hi, The curl command lack of "-L" option, cause download file fail, the size of download file is empty. ![image](https://github.com/openjdk/jdk/assets/24123821/7b5471ae-8e00-4a06-a327-7186c42bd6a6) Only change devkit shell script, the risk is low. - Commit messages: - 8331164