Re: RFR: 8337265: Test static-libs build in GitHub Actions

2024-09-03 Thread Doug Simon
On Tue, 3 Sep 2024 16:15:33 GMT, Erik Joelsson wrote: >> This PR modifies the GitHub Actions product build on Linux to include >> building of the static-libs bundle. >> This is a minimal smoke test to ensure these builds don't break. > > I think adding static libs to one platform and flavor comb

Re: RFR: 8337265: Test static-libs build in GitHub Actions

2024-09-03 Thread Magnus Ihse Bursie
On Sun, 1 Sep 2024 06:37:26 GMT, Doug Simon wrote: > This PR modifies the GitHub Actions product build on Linux to include > building of the static-libs bundle. > This is a minimal smoke test to ensure these builds don't break. Marked as reviewed by ihse (Reviewer). - PR Review: h

Re: RFR: 8337265: Test static-libs build in GitHub Actions

2024-09-03 Thread Erik Joelsson
On Sun, 1 Sep 2024 06:37:26 GMT, Doug Simon wrote: > This PR modifies the GitHub Actions product build on Linux to include > building of the static-libs bundle. > This is a minimal smoke test to ensure these builds don't break. I think adding static libs to one platform and flavor combination s

Re: RFR: 8337265: Test static-libs build in GitHub Actions

2024-09-02 Thread Doug Simon
On Mon, 2 Sep 2024 11:01:00 GMT, Magnus Ihse Bursie wrote: >> This PR modifies the GitHub Actions product build on Linux to include >> building of the static-libs bundle. >> This is a minimal smoke test to ensure these builds don't break. > > Also, you might not be aware of this, but I am workin

Re: RFR: 8337265: Test static-libs build in GitHub Actions

2024-09-02 Thread Magnus Ihse Bursie
On Sun, 1 Sep 2024 06:37:26 GMT, Doug Simon wrote: > This PR modifies the GitHub Actions product build on Linux to include > building of the static-libs bundle. > This is a minimal smoke test to ensure these builds don't break. Also, you might not be aware of this, but I am working on a redesig

Re: RFR: 8337265: Test static-libs build in GitHub Actions

2024-09-02 Thread Magnus Ihse Bursie
On Sun, 1 Sep 2024 06:37:26 GMT, Doug Simon wrote: > This PR modifies the GitHub Actions product build on Linux to include > building of the static-libs bundle. > This is a minimal smoke test to ensure these builds don't break. The code looks fine. However, the problem with GHA is that it is e

RFR: 8337265: Test static-libs build in GitHub Actions

2024-09-01 Thread Doug Simon
This PR modifies the GitHub Actions' linux product build to include building of the static-libs bundle as a minimal smoke test that these builds don't break. - Commit messages: - build static-libs on linux Changes: https://git.openjdk.org/jdk/pull/20803/files Webrev: https://webr