Re: RFR: JDK-8298908: Instrument Metaspace for ASan [v11]

2023-01-10 Thread Justin King
On Tue, 10 Jan 2023 21:55:51 GMT, Ioi Lam wrote: >> Justin King has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use macros from when available and update >> justification >> >> Signed-off-by: Justin King > > src/hotspot/share/san

Re: RFR: JDK-8298908: Instrument Metaspace for ASan [v11]

2023-01-10 Thread Ioi Lam
On Tue, 10 Jan 2023 17:27:33 GMT, Justin King wrote: >> This change instruments Metaspace for ASan. Metaspace allocates memory using >> `mmap`/`munmap` which ASan is not aware of. Fortunately ASan supports >> applications [manually poisoning/unpoisoning >> memory](https://github.com/google/san

Re: RFR: JDK-8298908: Instrument Metaspace for ASan [v11]

2023-01-10 Thread Justin King
> This change instruments Metaspace for ASan. Metaspace allocates memory using > `mmap`/`munmap` which ASan is not aware of. Fortunately ASan supports > applications [manually poisoning/unpoisoning > memory](https://github.com/google/sanitizers/wiki/AddressSanitizerManualPoisoning). > ASan is a