Re: RFR: JDK-8302801: Remove fdlibm C sources [v4]

2023-03-06 Thread Joe Darcy
On Sun, 5 Mar 2023 17:10:08 GMT, Joe Darcy wrote: > PS Successful Mach 5 job of default builds and tier 1 tests with this make > line present. PPS And for extra measure as suggested by David Holmes, a tier 1 through 5 build job was also successful. - PR: https://git.openjdk.org/j

Re: RFR: JDK-8302801: Remove fdlibm C sources [v4]

2023-03-05 Thread Vladimir Kozlov
On Sun, 5 Mar 2023 06:19:06 GMT, Joe Darcy wrote: >> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I >> thought I'd get out for the review the next phase of the FDLIBM port: >> removing the FDLIBM C sources from the repo. >> >> A repo with the changes for JDK-83020

Re: RFR: JDK-8302801: Remove fdlibm C sources [v4]

2023-03-05 Thread David Holmes
On Sun, 5 Mar 2023 06:19:06 GMT, Joe Darcy wrote: >> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I >> thought I'd get out for the review the next phase of the FDLIBM port: >> removing the FDLIBM C sources from the repo. >> >> A repo with the changes for JDK-83020

Re: RFR: JDK-8302801: Remove fdlibm C sources [v4]

2023-03-05 Thread Alan Bateman
On Sun, 5 Mar 2023 06:19:06 GMT, Joe Darcy wrote: >> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I >> thought I'd get out for the review the next phase of the FDLIBM port: >> removing the FDLIBM C sources from the repo. >> >> A repo with the changes for JDK-83020

Re: RFR: JDK-8302801: Remove fdlibm C sources [v4]

2023-03-05 Thread Joe Darcy
On Thu, 2 Mar 2023 18:27:09 GMT, Joe Darcy wrote: >> make/autoconf/buildjdk-spec.gmk.in line 85: >> >>> 83: JVM_LIBS := @OPENJDK_BUILD_JVM_LIBS@ >>> 84: >>> 85: FDLIBM_CFLAGS := @OPENJDK_BUILD_FDLIBM_CFLAGS@ >> >> If the hotspot build still needs `FDLIBM_CFLAGS`, then this line needs to >> st

Re: RFR: JDK-8302801: Remove fdlibm C sources [v4]

2023-03-04 Thread Joe Darcy
> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I > thought I'd get out for the review the next phase of the FDLIBM port: > removing the FDLIBM C sources from the repo. > > A repo with the changes for JDK-8302027 and this PR successful build on the > default set of