Re: RFR: JDK-8303166: Disable RTTI for Hotspot when building with MSVC [v3]

2023-02-26 Thread Justin King
On Sun, 26 Feb 2023 06:10:14 GMT, David Holmes wrote: > The workaround should have been done under JDK-8302817. This issue should > have simply disabled RTTI in the build system. I'll split the RTTI disable to a separate PR Monday, leave this one as the workaround, and rename to the other

Re: RFR: JDK-8303166: Disable RTTI for Hotspot when building with MSVC [v3]

2023-02-25 Thread David Holmes
On Fri, 24 Feb 2023 19:56:39 GMT, Justin King wrote: >> Disable RTTI `-GR-` for Hotspot when building with MSVC. This drops the size >> of `jvm.dll` by roughly 1 MB. Hotspot does not rely on RTTI and it is >> disabled for both GCC/Clang and Open XL C/C++ already. This change disables >> it

Re: RFR: JDK-8303166: Disable RTTI for Hotspot when building with MSVC [v3]

2023-02-25 Thread Kim Barrett
On Fri, 24 Feb 2023 19:56:39 GMT, Justin King wrote: >> Disable RTTI `-GR-` for Hotspot when building with MSVC. This drops the size >> of `jvm.dll` by roughly 1 MB. Hotspot does not rely on RTTI and it is >> disabled for both GCC/Clang and Open XL C/C++ already. This change disables >> it

Re: RFR: JDK-8303166: Disable RTTI for Hotspot when building with MSVC [v3]

2023-02-24 Thread Alex Menkov
On Fri, 24 Feb 2023 19:56:39 GMT, Justin King wrote: >> Disable RTTI `-GR-` for Hotspot when building with MSVC. This drops the size >> of `jvm.dll` by roughly 1 MB. Hotspot does not rely on RTTI and it is >> disabled for both GCC/Clang and Open XL C/C++ already. This change disables >> it

Re: RFR: JDK-8303166: Disable RTTI for Hotspot when building with MSVC [v3]

2023-02-24 Thread Justin King
> Disable RTTI `-GR-` for Hotspot when building with MSVC. This drops the size > of `jvm.dll` by roughly 1 MB. Hotspot does not rely on RTTI and it is > disabled for both GCC/Clang and Open XL C/C++ already. This change disables > it for MSVC, ensuring we do not accidently rely on RTTI for

Re: RFR: JDK-8303166: Disable RTTI for Hotspot when building with MSVC [v2]

2023-02-24 Thread Justin King
> Disable RTTI `-GR-` for Hotspot when building with MSVC. This drops the size > of `jvm.dll` by roughly 1 MB. Hotspot does not rely on RTTI and it is > disabled for both GCC/Clang and Open XL C/C++ already. This change disables > it for MSVC, ensuring we do not accidently rely on RTTI for

Re: RFR: JDK-8303166: Disable RTTI for Hotspot when building with MSVC

2023-02-24 Thread Chris Plummer
On Fri, 24 Feb 2023 15:36:16 GMT, Justin King wrote: > Disable RTTI `-GR-` for Hotspot when building with MSVC. This drops the size > of `jvm.dll` by roughly 1 MB. Hotspot does not rely on RTTI and it is > disabled for both GCC/Clang and Open XL C/C++ already. This change disables > it for

RFR: JDK-8303166: Disable RTTI for Hotspot when building with MSVC

2023-02-24 Thread Justin King
Disable RTTI `-GR-` for Hotspot when building with MSVC. This drops the size of `jvm.dll` by roughly 1 MB. Hotspot does not rely on RTTI and it is disabled for both GCC/Clang and Open XL C/C++ already. This change disables it for MSVC, ensuring we do not accidently rely on RTTI for