Re: RFR: JDK-8303476: Add the runtime version in the release file of a JDK image

2023-03-01 Thread Mandy Chung
On Wed, 1 Mar 2023 20:28:14 GMT, Mandy Chung wrote: > `$JAVA_HOME/release` file currently includes `JAVA_VERSION` which is the > version > number plus the pre-release identifier for example "21-ea".The build > number > and additional build information are useful in identifying the inform

Re: RFR: JDK-8303476: Add the runtime version in the release file of a JDK image

2023-03-01 Thread Erik Joelsson
On Wed, 1 Mar 2023 21:24:34 GMT, Mandy Chung wrote: > > I can't actually find that in the current release file, but that shouldn't > > prevent us from adding the full version string. > > `JAVA_VERSION` is added by jlink and not in ReleaseFile.gmk. Ah, that explains it, if I look in images/jdk/

Re: RFR: JDK-8303476: Add the runtime version in the release file of a JDK image [v2]

2023-03-01 Thread Erik Joelsson
On Wed, 1 Mar 2023 21:30:21 GMT, Mandy Chung wrote: >> `$JAVA_HOME/release` file currently includes `JAVA_VERSION` which is the >> version >> number plus the pre-release identifier for example "21-ea".The build >> number >> and additional build information are useful in identifying the i

Re: RFR: JDK-8303476: Add the runtime version in the release file of a JDK image

2023-03-01 Thread Mandy Chung
On Wed, 1 Mar 2023 21:20:18 GMT, Erik Joelsson wrote: > I can't actually find that in the current release file, but that shouldn't > prevent us from adding the full version string. `JAVA_VERSION` is added by jlink and not in ReleaseFile.gmk. - PR: https://git.openjdk.org/jdk/pull/

Re: RFR: JDK-8303476: Add the runtime version in the release file of a JDK image [v2]

2023-03-01 Thread Mandy Chung
> `$JAVA_HOME/release` file currently includes `JAVA_VERSION` which is the > version > number plus the pre-release identifier for example "21-ea".The build > number > and additional build information are useful in identifying the information > about a JDK image but not available. This pr

Re: RFR: JDK-8303476: Add the runtime version in the release file of a JDK image

2023-03-01 Thread Erik Joelsson
On Wed, 1 Mar 2023 20:28:14 GMT, Mandy Chung wrote: > `$JAVA_HOME/release` file currently includes `JAVA_VERSION` which is the > version > number plus the pre-release identifier for example "21-ea". I can't actually find that in the current release file, but that shouldn't prevent us from addi

RFR: JDK-8303476: Add the runtime version in the release file of a JDK image

2023-03-01 Thread Mandy Chung
`$JAVA_HOME/release` file currently includes `JAVA_VERSION` which is the version number plus the pre-release identifier for example "21-ea".The build number and additional build information are useful in identifying the information about a JDK image but not available. This proposes to add