Re: RFR: JDK-8306983: Do not invoke external programs when switch terminal to raw mode on selected platforms [v2]

2023-05-11 Thread Jan Lahoda
On Tue, 9 May 2023 20:49:16 GMT, Brian Burkhalter wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adjusting build script as suggested on the review. > > src/jdk.internal.le/linux/native/lible/CLibrary.cpp line 183:

Re: RFR: JDK-8306983: Do not invoke external programs when switch terminal to raw mode on selected platforms [v2]

2023-05-09 Thread Brian Burkhalter
On Fri, 5 May 2023 12:34:29 GMT, Jan Lahoda wrote: >> To support JShell and other usecases, the JDK uses JLine, which provides >> line-editing functionality inside a terminal. >> >> JLine has several ways to work with the terminal, based on various >> additional libraries and tools. Most of

Re: RFR: JDK-8306983: Do not invoke external programs when switch terminal to raw mode on selected platforms [v2]

2023-05-05 Thread Erik Joelsson
On Fri, 5 May 2023 12:34:29 GMT, Jan Lahoda wrote: >> To support JShell and other usecases, the JDK uses JLine, which provides >> line-editing functionality inside a terminal. >> >> JLine has several ways to work with the terminal, based on various >> additional libraries and tools. Most of

Re: RFR: JDK-8306983: Do not invoke external programs when switch terminal to raw mode on selected platforms [v2]

2023-05-05 Thread Jan Lahoda
> To support JShell and other usecases, the JDK uses JLine, which provides > line-editing functionality inside a terminal. > > JLine has several ways to work with the terminal, based on various additional > libraries and tools. Most of them are not directly usable inside the JDK, so >