Re: RFR: JDK-8318961: increase javacserver connection timeout values and max retry attempts [v2]

2023-10-30 Thread Matthias Baesken
On Mon, 30 Oct 2023 09:29:05 GMT, Matthias Baesken wrote: >> Increase javacserver connection timeout values and max retry attempts for >> better make stability on some slower machines. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last

Re: RFR: JDK-8318961: increase javacserver connection timeout values and max retry attempts [v2]

2023-10-30 Thread Erik Joelsson
On Mon, 30 Oct 2023 09:29:05 GMT, Matthias Baesken wrote: >> Increase javacserver connection timeout values and max retry attempts for >> better make stability on some slower machines. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last

Re: RFR: JDK-8318961: increase javacserver connection timeout values and max retry attempts [v2]

2023-10-30 Thread Matthias Baesken
> Increase javacserver connection timeout values and max retry attempts for > better make stability on some slower machines. Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: Adjust WAIT_BETWEEN_CONNECT_ATTEMPTS -

Re: RFR: JDK-8318961: increase javacserver connection timeout values and max retry attempts

2023-10-30 Thread Matthias Baesken
On Fri, 27 Oct 2023 10:43:58 GMT, Matthias Baesken wrote: > Increase javacserver connection timeout values and max retry attempts for > better make stability on some slower machines. I adjusted the WAIT_BETWEEN_CONNECT_ATTEMPTS; Let's how this works. - PR Comment:

Re: RFR: JDK-8318961: increase javacserver connection timeout values and max retry attempts

2023-10-27 Thread Erik Joelsson
On Fri, 27 Oct 2023 10:43:58 GMT, Matthias Baesken wrote: > Increase javacserver connection timeout values and max retry attempts for > better make stability on some slower machines. make/langtools/tools/javacserver/client/Client.java line 57: > 55: private static final int

Re: RFR: JDK-8318961: increase javacserver connection timeout values and max retry attempts

2023-10-27 Thread Christoph Langer
On Fri, 27 Oct 2023 10:43:58 GMT, Matthias Baesken wrote: > Increase javacserver connection timeout values and max retry attempts for > better make stability on some slower machines. Looks good to me, these changes seem to have improved nightbuilds at SAP. But somebody from build group should

RFR: JDK-8318961: increase javacserver connection timeout values and max retry attempts

2023-10-27 Thread Matthias Baesken
Increase javacserver connection timeout values and max retry attempts for better make stability on some slower machines. - Commit messages: - JDK-8318961 Changes: https://git.openjdk.org/jdk/pull/16397/files Webrev: https://webrevs.openjdk.org/?repo=jdk=16397=00 Issue: