Re: RFR: JDK-8323008: filter out any -std* flags added by autoconf from CC/CXX [v4]

2024-01-11 Thread Matthias Baesken
On Thu, 11 Jan 2024 14:31:47 GMT, Matthias Baesken wrote: >> It was observed, that autoconf 2.72 added on macOS x86_64 the flag >> -std=gnu++11 by default to CXX in the configure process . >> This is not really wanted so better remove / filter out any -std* flags >> added by autoconf from

Re: RFR: JDK-8323008: filter out any -std* flags added by autoconf from CC/CXX [v4]

2024-01-11 Thread Christoph Langer
On Thu, 11 Jan 2024 14:31:47 GMT, Matthias Baesken wrote: >> It was observed, that autoconf 2.72 added on macOS x86_64 the flag >> -std=gnu++11 by default to CXX in the configure process . >> This is not really wanted so better remove / filter out any -std* flags >> added by autoconf from

Re: RFR: JDK-8323008: filter out any -std* flags added by autoconf from CC/CXX [v4]

2024-01-11 Thread Christoph Langer
On Thu, 11 Jan 2024 14:31:47 GMT, Matthias Baesken wrote: >> It was observed, that autoconf 2.72 added on macOS x86_64 the flag >> -std=gnu++11 by default to CXX in the configure process . >> This is not really wanted so better remove / filter out any -std* flags >> added by autoconf from

Re: RFR: JDK-8323008: filter out any -std* flags added by autoconf from CC/CXX

2024-01-11 Thread Matthias Baesken
On Thu, 11 Jan 2024 13:54:01 GMT, Christoph Langer wrote: > Makes sense. It's the same pattern. I adjusted the second GREP too and removed the` if test` . - PR Comment: https://git.openjdk.org/jdk/pull/17301#issuecomment-1887318284

Re: RFR: JDK-8323008: filter out any -std* flags added by autoconf from CC/CXX [v4]

2024-01-11 Thread Matthias Baesken
> It was observed, that autoconf 2.72 added on macOS x86_64 the flag > -std=gnu++11 by default to CXX in the configure process . > This is not really wanted so better remove / filter out any -std* flags added > by autoconf from CC/CXX . > > Seems we have something similar for some time for

Re: RFR: JDK-8323008: filter out any -std* flags added by autoconf from CC/CXX

2024-01-11 Thread Christoph Langer
On Thu, 11 Jan 2024 13:08:52 GMT, Matthias Baesken wrote: > Thanks , seems GREP was indeed 'harmed' by the parameters we use here. Btw > there is a similar place here where we would run into the same issue > >

Re: RFR: JDK-8323008: filter out any -std* flags added by autoconf from CC/CXX [v3]

2024-01-11 Thread Christoph Langer
On Thu, 11 Jan 2024 11:19:01 GMT, Magnus Ihse Bursie wrote: >> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> adjust COPYRIGHT year > > make/autoconf/toolchain.m4 line 395: > >> 393: # filter out some unwanted

Re: RFR: JDK-8323008: filter out any -std* flags added by autoconf from CC/CXX [v3]

2024-01-11 Thread Matthias Baesken
> It was observed, that autoconf 2.72 added on macOS x86_64 the flag > -std=gnu++11 by default to CXX in the configure process . > This is not really wanted so better remove / filter out any -std* flags added > by autoconf from CC/CXX . > > Seems we have something similar for some time for

Re: RFR: JDK-8323008: filter out any -std* flags added by autoconf from CC/CXX [v2]

2024-01-11 Thread Matthias Baesken
On Thu, 11 Jan 2024 11:19:01 GMT, Magnus Ihse Bursie wrote: >> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adjust GREP call > > make/autoconf/toolchain.m4 line 395: > >> 393: # filter out some unwanted additions

Re: RFR: JDK-8323008: filter out any -std* flags added by autoconf from CC/CXX

2024-01-11 Thread Matthias Baesken
On Thu, 11 Jan 2024 11:06:02 GMT, Christoph Langer wrote: > > Strange, I noticed that for some reason the > > UTIL_GET_NON_MATCHING_VALUES(cxx_filtered, $CXX, -std=c++11 -std=gnu++11) > > seems not to remove the flags as expected, did I misinterpret how > > UTIL_GET_NON_MATCHING_VALUES works

Re: RFR: JDK-8323008: filter out any -std* flags added by autoconf from CC/CXX [v2]

2024-01-11 Thread Matthias Baesken
> It was observed, that autoconf 2.72 added on macOS x86_64 the flag > -std=gnu++11 by default to CXX in the configure process . > This is not really wanted so better remove / filter out any -std* flags added > by autoconf from CC/CXX . > > Seems we have something similar for some time for

Re: RFR: JDK-8323008: filter out any -std* flags added by autoconf from CC/CXX

2024-01-11 Thread Magnus Ihse Bursie
On Mon, 8 Jan 2024 10:16:21 GMT, Matthias Baesken wrote: > It was observed, that autoconf 2.72 added on macOS x86_64 the flag > -std=gnu++11 by default to CXX in the configure process . > This is not really wanted so better remove / filter out any -std* flags added > by autoconf from CC/CXX .

Re: RFR: JDK-8323008: filter out any -std* flags added by autoconf from CC/CXX

2024-01-11 Thread Christoph Langer
On Tue, 9 Jan 2024 16:18:08 GMT, Matthias Baesken wrote: > Strange, I noticed that for some reason the > UTIL_GET_NON_MATCHING_VALUES(cxx_filtered, $CXX, -std=c++11 -std=gnu++11) > seems not to remove the flags as expected, did I misinterpret how > UTIL_GET_NON_MATCHING_VALUES works ? Any

Re: RFR: JDK-8323008: filter out any -std* flags added by autoconf from CC/CXX

2024-01-10 Thread Julian Waters
On Wed, 10 Jan 2024 07:44:47 GMT, Matthias Baesken wrote: > That might be a bit tricky, because on my macOS test machine, with a self > compiled autoconf 2.72, I did not even get this strange behavior. But it was > a different macOS version . So it seems to be a problem of very specific >

Re: RFR: JDK-8323008: filter out any -std* flags added by autoconf from CC/CXX

2024-01-09 Thread Matthias Baesken
On Tue, 9 Jan 2024 17:03:43 GMT, Julian Waters wrote: > Rather than filtering through the added flags like this, is it possible to > figure out why macOS trips the C++11 heuristic and fix the problem there? That might be a bit tricky, because on my macOS test machine, with a self compiled

Re: RFR: JDK-8323008: filter out any -std* flags added by autoconf from CC/CXX

2024-01-09 Thread Julian Waters
On Mon, 8 Jan 2024 10:16:21 GMT, Matthias Baesken wrote: > It was observed, that autoconf 2.72 added on macOS x86_64 the flag > -std=gnu++11 by default to CXX in the configure process . > This is not really wanted so better remove / filter out any -std* flags added > by autoconf from CC/CXX .

Re: RFR: JDK-8323008: filter out any -std* flags added by autoconf from CC/CXX

2024-01-09 Thread Matthias Baesken
On Mon, 8 Jan 2024 10:16:21 GMT, Matthias Baesken wrote: > It was observed, that autoconf 2.72 added on macOS x86_64 the flag > -std=gnu++11 by default to CXX in the configure process . > This is not really wanted so better remove / filter out any -std* flags added > by autoconf from CC/CXX .

Re: RFR: JDK-8323008: filter out any -std* flags added by autoconf from CC/CXX

2024-01-08 Thread Erik Joelsson
On Mon, 8 Jan 2024 10:16:21 GMT, Matthias Baesken wrote: > It was observed, that autoconf 2.72 added on macOS x86_64 the flag > -std=gnu++11 by default to CXX in the configure process . > This is not really wanted so better remove / filter out any -std* flags added > by autoconf from CC/CXX .

RFR: JDK-8323008: filter out any -std* flags added by autoconf from CC/CXX

2024-01-08 Thread Matthias Baesken
It was observed, that autoconf 2.72 added on macOS x86_64 the flag -std=gnu++11 by default to CXX in the configure process . This is not really wanted so better remove / filter out any -std* flags added by autoconf from CC/CXX . Seems we have something similar for some time for CFLAGS and