Re: RFR: JDK-8323008: filter out harmful -std* flags added by autoconf from CXX [v4]

2024-01-12 Thread Christoph Langer
On Fri, 12 Jan 2024 13:39:33 GMT, Matthias Baesken wrote: > > As I mentioned above, the autoconf inserting of those compiler flags can be > > disabled by setting ac_prog_cc_stdc and >ac_prog_cxx_stdcxx to readonly > > empty values. It's also a workaround, but is slightly less hacky than > >

Re: RFR: JDK-8323008: filter out harmful -std* flags added by autoconf from CXX [v4]

2024-01-12 Thread Magnus Ihse Bursie
On Fri, 12 Jan 2024 13:33:54 GMT, Julian Waters wrote: > The only downside to that solution on the other hand is the shell will issue > a diagnostic about writing to a readonly var. Not sure if that is an > acceptable tradeoff That definitely sounds worse. - PR Comment:

Re: RFR: JDK-8323008: filter out harmful -std* flags added by autoconf from CXX [v4]

2024-01-12 Thread Matthias Baesken
On Fri, 12 Jan 2024 13:32:28 GMT, Julian Waters wrote: >As I mentioned above, the autoconf inserting of those compiler flags can be >disabled by setting ac_prog_cc_stdc and >ac_prog_cxx_stdcxx to readonly empty >values. It's also a workaround, but is slightly less hacky than filtering out

Re: RFR: JDK-8323008: filter out harmful -std* flags added by autoconf from CXX [v4]

2024-01-12 Thread Julian Waters
On Thu, 11 Jan 2024 14:31:47 GMT, Matthias Baesken wrote: >> It was observed, that autoconf 2.72 added on macOS x86_64 the flag >> -std=gnu++11 by default to CXX in the configure process . >> This is not really wanted so better remove / filter out those -std* flags >> added by autoconf from

Re: RFR: JDK-8323008: filter out harmful -std* flags added by autoconf from CXX [v4]

2024-01-12 Thread Julian Waters
On Fri, 12 Jan 2024 11:35:48 GMT, Magnus Ihse Bursie wrote: > The grep fixes are excellent, thank you for those! > > The CXX filtering is a hack, and I'm slightly less happy about that. Otoh, > the entire autoconf compiler detection stuff is so-so, and we're basically > trying to avoid

Re: RFR: JDK-8323008: filter out harmful -std* flags added by autoconf from CXX [v4]

2024-01-12 Thread Matthias Baesken
On Thu, 11 Jan 2024 14:31:47 GMT, Matthias Baesken wrote: >> It was observed, that autoconf 2.72 added on macOS x86_64 the flag >> -std=gnu++11 by default to CXX in the configure process . >> This is not really wanted so better remove / filter out those -std* flags >> added by autoconf from

Re: RFR: JDK-8323008: filter out harmful -std* flags added by autoconf from CXX [v4]

2024-01-12 Thread Magnus Ihse Bursie
On Thu, 11 Jan 2024 14:31:47 GMT, Matthias Baesken wrote: >> It was observed, that autoconf 2.72 added on macOS x86_64 the flag >> -std=gnu++11 by default to CXX in the configure process . >> This is not really wanted so better remove / filter out those -std* flags >> added by autoconf from