Re: [External] : Re: Where is STRIP set for clang?

2022-08-26 Thread Julian Waters
On an even closer inspection, the strip used currently on MacOS is actually XCode strip and not the one that comes with LLVM, do we already have an XCode check that can be piggybacked off at the moment? best regards, Julian On Tue, Aug 2, 2022 at 1:30 PM Julian Waters wrote: > After a quick ref

Re: [External] : Re: Where is STRIP set for clang?

2022-08-01 Thread Julian Waters
After a quick reference through documentation, it appears that LLVM strip uses the exact same flags that gcc's strip uses, at least for the only 2 strip modes we use (--strip-debug, or shortened to just -g, and --strip-unneeded), meaning we can fortunately fold both into the same branch (The curren

Re: [External] : Re: Where is STRIP set for clang?

2022-08-01 Thread erik . joelsson
On 7/27/22 7:46 PM, Julian Waters wrote: What would be a good way to test for the strip executable? The easiest solution off the top of my head is to assume a particular compiler uses a particular strip, but that sounds a little too inflexible. Maybe assuming based on toolchain is good enough,

Re: Where is STRIP set for clang?

2022-07-27 Thread Julian Waters
What would be a good way to test for the strip executable? The easiest solution off the top of my head is to assume a particular compiler uses a particular strip, but that sounds a little too inflexible. best regards, Julian On Wed, Jul 27, 2022 at 1:04 AM wrote: > I'm not very familiar with th

Re: Where is STRIP set for clang?

2022-07-26 Thread erik . joelsson
I'm not very familiar with this, but it looks like clang/llvm does come with its own strip utility, which would make this comment wrong. On Linux, it's likely common to find the gnu binutils strip on the path even when trying to use clang to compile OpenJDK. Ideally we should setup STRIPFLAGS

Where is STRIP set for clang?

2022-07-24 Thread Julian Waters
Found something interesting in FLAGS_SETUP_STRIPFLAGS recently: ## Setup strip. # FIXME: should this really be per platform, or should it be per toolchain type? # strip is not provided by clang; so guessing platform makes most sense. STRIPFLAGS is set to -S after this for clang (or more accurately