Re: Remove common patterns -- second try

2007-09-30 Thread Loïc Grenié
2007/9/30, Denys Vlasenko <[EMAIL PROTECTED]>: > On Sunday 30 September 2007 15:30, Loïc Grenié wrote: > > I've tried to remove "common patterns" in the code. > > Second try: I've changed bb_\(p?\)error_msg\(_and_die\)("%s", \(.*\)) > > in bb_simple_\1error_msg\2(\3). > > > >Patch attache

Re: Remove common patterns -- second try

2007-09-30 Thread Denys Vlasenko
On Sunday 30 September 2007 15:30, Loïc Grenié wrote: > I've tried to remove "common patterns" in the code. > Second try: I've changed bb_\(p?\)error_msg\(_and_die\)("%s", \(.*\)) > in bb_simple_\1error_msg\2(\3). > >Patch attached. > > Loïc May I suggest a simpler approach? M

Re: pgrep/pkill

2007-09-30 Thread Denys Vlasenko
On Sunday 30 September 2007 09:09, Loïc Grenié wrote: > > There was a typo at line 122 of pgrep.c and I made an error: kill > > cannot exit. I've modified print_signames_and_exit in print_signames > > and added a return EXIT_SUCCESS; to pgrep_main. > > Forgot to attach before sending.

Re: Remove common patterns -- second try

2007-09-30 Thread Denys Vlasenko
On Sunday 30 September 2007 15:30, Loïc Grenié wrote: > I've tried to remove "common patterns" in the code. > Second try: I've changed bb_\(p?\)error_msg\(_and_die\)("%s", \(.*\)) > in bb_simple_\1error_msg\2(\3). -#ifdef VERSION_WITH_WRITEV -. -#endif Why did you remove it? cc1: war

Re: Remove common patterns

2007-09-30 Thread Denys Vlasenko
On Sunday 30 September 2007 15:28, Loïc Grenié wrote: > I've tried to remove "common patterns" in the code. > First try: s/printf("%s", /puts(/ and s/fprintf(fp, "%s", > \(.*\))/fputs(\1, fp)/ > Patch attached. - printf("%s", error_message(ctx->errcode)); + put

Re: Missing breaks in do_iproute ?

2007-09-30 Thread Denys Vlasenko
On Sunday 30 September 2007 15:21, Loïc Grenié wrote: > I think do_iproute is missing 3 breaks inside the switch. > > Patch attached. Applied, thanks -- vda ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman/listinfo

Remove common patterns -- second try

2007-09-30 Thread Loïc Grenié
I've tried to remove "common patterns" in the code. Second try: I've changed bb_\(p?\)error_msg\(_and_die\)("%s", \(.*\)) in bb_simple_\1error_msg\2(\3). Patch attached. Loïc Index: networking/libiproute/iproute.c ==

Remove common patterns

2007-09-30 Thread Loïc Grenié
I've tried to remove "common patterns" in the code. First try: s/printf("%s", /puts(/ and s/fprintf(fp, "%s", \(.*\))/fputs(\1, fp)/ Patch attached. Loïc Index: networking/libiproute/iprule.c === --- networking/libipr

Missing breaks in do_iproute ?

2007-09-30 Thread Loïc Grenié
I think do_iproute is missing 3 breaks inside the switch. Patch attached. Loïc Index: networking/libiproute/iproute.c === --- networking/libiproute/iproute.c (révision 20138) +++ networking/libiproute/iproute.c (cop

Re: Question about 'busybox_ld.err' and 'busybox_ld.out'?

2007-09-30 Thread Mike Frysinger
On Sunday 30 September 2007, 志達 wrote: > *** Sorry! forget to attach the file in the previous mail *** for future reference, proper edict is to reply to your previous mail with the attachment, not double post > The output I got is summarized as below. > > -rwxr-xr-x 1 snoopy snoopy 70088 2007-09

Question about 'busybox_ld.err' and 'busybox_ld.out'?

2007-09-30 Thread 志達
Dear All, I had tried to learn the busybox and to build a execution image for my test platform (mips system). First, I input the following instructions to build the busybox. make defnoconfig make CROSS_COMPILE=mips-linux- The output I got is summarized as below. -rwxr-xr-x 1 snoopy snoopy 7008

Question about 'busybox_ld.err' and 'busybox_ld.out'?

2007-09-30 Thread 志達
Dear All, *** Sorry! forget to attach the file in the previous mail *** I had tried to learn the busybox and to build a execution image for my test platform (mips system). First, I input the following instructions to build the busybox. make defnoconfig make CROSS_COMPILE=mips-linux- The output

Re: pgrep/pkill

2007-09-30 Thread Loïc Grenié
2007/9/30, Loïc Grenié <[EMAIL PROTECTED]>: > 2007/9/30, Denys Vlasenko <[EMAIL PROTECTED]>: > > On Saturday 29 September 2007 04:14, Loïc Grenié wrote: > > > > > > Here it is. I've tried to take care of all the remarks. > > > > > >Loïc > > > > /* How to determine who we are? find 3rd

Re: pgrep/pkill

2007-09-30 Thread Loïc Grenié
2007/9/30, Denys Vlasenko <[EMAIL PROTECTED]>: > On Saturday 29 September 2007 04:14, Loïc Grenié wrote: > > > > Here it is. I've tried to take care of all the remarks. > > > >Loïc > > /* How to determine who we are? find 3rd char from the end: > * kill, killall, killall5 > - * ^i