On Wednesday 26 November 2008 03:40, Aras Vaichas wrote:
> I just upgraded from 1.12.0 to 1.13.0 and noticed that many of my shell
> scripts seg faulted. I traced the problem to "here documents" inside
> nested functions.
>
> Here is an test example:
>
> --- SNIP ---
> #!/bin/sh
> function1() {
>
On Tuesday 25 November 2008 23:22, Wilmer van der Gaast wrote:
> Hey Denys!
>
> 2008/11/25 Denys Vlasenko <[EMAIL PROTECTED]>:
> >
> > Try attached patch
>
> Done. The problem's partially fixed:
>
> /tmp # ./ash -c 'echo 1&'
> 1
>
> However, the & is still not detected. This can be tested using
On Thursday 27 November 2008 17:59, Gilles Espinasse wrote:
> > >
> > > Can you try just replacing
> > >
> > >while (*envp)
> > > putenv(*envp++);
> > >
> > > with
> > >
> > >environ = envp;
> > >
> > > Does this work?
> >
> First I find a very different issue that may explain the p
Just a simple cleanup patch.
Please consider applying.
Cheers,
--
CristianIndex: busybox/miscutils/last_fancy.c
===
--- busybox/miscutils/last_fancy.c (revision 23984)
+++ busybox/miscutils/last_fancy.c (working copy)
@@ -18,10 +18
>
> In my code if I open I close; the same with the add - remove pair.
>
close()ing files and free()ing memory are likely to have sence when
iteratively working with unlimited or potentially large number of these
resources. At least, it is common practice in BB. Just let us trust the
system.
Best
Vladimir,
1. When I was discovering that the inotify existed you were already an expert.
2. In my code if I open I close; the same with the add - remove pair.
3. Now I know that inotify can remove some watches internally and the close()
was implemented to do all the required cleanup. So I would j
>
> According to http://www.linuxjournal.com/article/8478 - close() will do
> all the required cleanup job.
>
It was you, Piotr, who requested for ...to have inotify_rm_watch() for each
inotify_add_watch() call... :)
I, personally, turn FEATURE_CLEAN_UP off and rely upon the system
housekeeping.
>
> There is another way.
>
> Configure busybox to build ONLY chpasswd applet. Build it.
> rename resulting busybox as "chpasswd". Use it as standalone
> application. No need to replace existing busybox binary,
> just add this one.
>
> Newer versions of busybox even detect "only one applet" case
>
According to http://www.linuxjournal.com/article/8478 - close() will do all the
required cleanup job.
"To destroy any existing watches, pending events and the inotify instance
itself, invoke the close() system call on the inotify instance's file
descriptor."
Best Regards,
Piotr
I would g
- Original Message -
From: "Gilles Espinasse" <[EMAIL PROTECTED]>
To: "Denys Vlasenko" <[EMAIL PROTECTED]>
Cc: "Busybox"
Sent: Tuesday, November 25, 2008 8:14 AM
Subject: Re: busybox-1.12.1=>1.12.2 ash regression
> >
> > Can you try just replacing
> >
> >while (*envp)
> > p
>
> I would gladly review a patch ;)
Well, take a look at http://drvv.ru/busybox/inotifyd.patch .
If it fits, please apply.
--
Vladimir
___
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
11 matches
Mail list logo
