Re: [PATCH] busybox binary name

2011-03-01 Thread Tobias Poschwatta
On Wed, Mar 02, 2011 at 02:19:02AM +0100, Denys Vlasenko wrote: > On Tuesday 01 March 2011 22:08, Tobias Poschwatta wrote: > > The attached patch allows to change the name of the main busybox binary > > to something other than "busybox". This makes it easy to have two or > > more busybox binaries (

Re: Compiling busybox to .s assembly file

2011-03-01 Thread Eric Schulte
Denys Vlasenko writes: > On Thursday 24 February 2011 18:17, Eric Schulte wrote: >> Hello, >> >> I'm hoping to generate a compiled text asm file (gcc -S) of the busybox >> executable. I've looked at scripts/showasm, but it uses objdump the >> output of which could not (easily) then be edited an

Re: [PATCH 2/3] free allocated iface and liface before return

2011-03-01 Thread Denys Vlasenko
On Tuesday 01 March 2011 12:38, Alexey Fomenko wrote: > xstrdup allocates buffer to iface, liface. Needs to be freed. > > Signed-off-by: Alexey Fomenko > --- > networking/ifupdown.c |7 +-- > networking/nameif.c |6 ++ > 2 files changed, 7 insertions(+), 6 deletions(-) > > dif

Re: [PATCH 3/3] Add missing fclose()

2011-03-01 Thread Denys Vlasenko
On Tuesday 01 March 2011 12:39, Alexey Fomenko wrote: > After opening fp and cin need to be closed. > > Signed-off-by: Alexey Fomenko > --- > networking/route.c |2 ++ > util-linux/more.c |1 + > 2 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/networking/route.c b/net

Re: 2 issues with tar

2011-03-01 Thread Alexander Shishkin
On Wed, Mar 02, 2011 at 12:58:58AM +0100, Denys Vlasenko wrote: > On Tuesday 01 March 2011 21:14, Alexander Shishkin wrote: > > On 1 March 2011 18:18, Denys Vlasenko wrote: > > > On Monday 28 February 2011 09:23, Alexey Soloviev wrote: > > >> Hello, > > >> Met 2 problems with tar and wander if the

Re: Busybox-1.18.3 mconf.c

2011-03-01 Thread Denys Vlasenko
On Tuesday 01 March 2011 21:13, Tobias Poschwatta wrote: > I think busybox 1.18.3 needs > > commit 5a746dcec5c1e09c3cff0326c3b205d2427861f0 > Author: Denys Vlasenko > Date: Mon Feb 7 02:19:02 2011 +0100 > > scripts/kconfig/mconf.c: stop-gap fix for buffer overflow > > Signed-off-b

Re: [PATCH] busybox binary name

2011-03-01 Thread Denys Vlasenko
On Tuesday 01 March 2011 22:08, Tobias Poschwatta wrote: > The attached patch allows to change the name of the main busybox binary > to something other than "busybox". This makes it easy to have two or > more busybox binaries (different versions, different feature sets, etc.) > installed in the sam

Re: 2 issues with tar

2011-03-01 Thread Denys Vlasenko
On Wednesday 02 March 2011 00:58, Denys Vlasenko wrote: > On Tuesday 01 March 2011 21:14, Alexander Shishkin wrote: > > On 1 March 2011 18:18, Denys Vlasenko wrote: > > > On Monday 28 February 2011 09:23, Alexey Soloviev wrote: > > >> Hello, > > >> Met 2 problems with tar and wander if they are ne

Re: 2 issues with tar

2011-03-01 Thread Denys Vlasenko
On Tuesday 01 March 2011 21:14, Alexander Shishkin wrote: > On 1 March 2011 18:18, Denys Vlasenko wrote: > > On Monday 28 February 2011 09:23, Alexey Soloviev wrote: > >> Hello, > >> Met 2 problems with tar and wander if they are new or known. > >> > >> Issue 1: tar doesn't restore files or direct

Proposed More patch

2011-03-01 Thread Cathey, Jim
Please forgive the un-real patch-oid format, but we're not set up to do it better right now. We've got a script that pipes GNU ls -C into BB more, and it really messes up the tabs. I made a quick patch to more.c which seems to help. Any reason this shouldn't be permanent? The crude conversion is

[PATCH] busybox binary name

2011-03-01 Thread Tobias Poschwatta
The attached patch allows to change the name of the main busybox binary to something other than "busybox". This makes it easy to have two or more busybox binaries (different versions, different feature sets, etc.) installed in the same filesystem. The patch adds a new config option (CONFIG_BINARY_

Busybox-1.18.3 mconf.c

2011-03-01 Thread Tobias Poschwatta
Denys, I think busybox 1.18.3 needs commit 5a746dcec5c1e09c3cff0326c3b205d2427861f0 Author: Denys Vlasenko Date: Mon Feb 7 02:19:02 2011 +0100 scripts/kconfig/mconf.c: stop-gap fix for buffer overflow Signed-off-by: Denys Vlasenko Without this change, menuconfig stops working

Re: 2 issues with tar

2011-03-01 Thread Alexander Shishkin
On 1 March 2011 18:18, Denys Vlasenko wrote: > On Monday 28 February 2011 09:23, Alexey Soloviev wrote: >> Hello, >> Met 2 problems with tar and wander if they are new or known. >> >> Issue 1: tar doesn't restore files or directories added with relative >> name starting with "../" >> Scenario: >>

Re: [PATCH 1/3] removed dead code. pargv was set NULL before cycle manually

2011-03-01 Thread Denys Vlasenko
On Tuesday 01 March 2011 12:38, Alexey Fomenko wrote: > Manually setting pargv = NULL gives dead code. Looks like it's unused > anyway. > > Signed-off-by: Alexey Fomenko > --- > libbb/getopt32.c |4 > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/libbb/getopt32.c b

Re: Ping

2011-03-01 Thread Denys Vlasenko
On Tuesday 01 March 2011 12:41, Bernd Petrovitsch wrote: > > Hi! > On Die, 2011-03-01 at 12:08 +0100, Harald Becker wrote: > [...] > > >> Is the mailing list down? ... please ignore, it's just a self test. > > > Ever read https://www.kernel.org/pub/linux/docs/lkml/#s3-15? > > > > Did you read th

Re: 2 issues with tar

2011-03-01 Thread Denys Vlasenko
On Monday 28 February 2011 09:23, Alexey Soloviev wrote: > Hello, > Met 2 problems with tar and wander if they are new or known. > > Issue 1: tar doesn't restore files or directories added with relative > name starting with "../" > Scenario: > busybox tar -c -f archive.tar ../tobearchived > busyb

Re: 2 issues with tar

2011-03-01 Thread Denys Vlasenko
On Monday 28 February 2011 09:23, Alexey Soloviev wrote: > Hello, > Met 2 problems with tar and wander if they are new or known. > > Issue 1: tar doesn't restore files or directories added with relative > name starting with "../" > Scenario: > busybox tar -c -f archive.tar ../tobearchived > busyb

Re: [PATCH] tar: remove leading / and ../ on reading and writing

2011-03-01 Thread Alexander Shishkin
On Mon, Feb 28, 2011 at 11:48:44PM +0100, Ralf Friedl wrote: > Alexander Shishkin wrote: > >Currently, tar will add members with names starting with > >the prefixes to an archive unmodified, and will then refuse > >to extract from such archive. However, GNU tar will strip > >these prefixes upon cre

[PATCH 3/3] Add missing fclose()

2011-03-01 Thread Alexey Fomenko
After opening fp and cin need to be closed. Signed-off-by: Alexey Fomenko --- networking/route.c |2 ++ util-linux/more.c |1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/networking/route.c b/networking/route.c index b7d08dd..18cb902 100644 --- a/networking/route.c +

[PATCH 2/3] free allocated iface and liface before return

2011-03-01 Thread Alexey Fomenko
xstrdup allocates buffer to iface, liface. Needs to be freed. Signed-off-by: Alexey Fomenko --- networking/ifupdown.c |7 +-- networking/nameif.c |6 ++ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/networking/ifupdown.c b/networking/ifupdown.c index 59df4e8..5

[PATCH 1/3] removed dead code. pargv was set NULL before cycle manually

2011-03-01 Thread Alexey Fomenko
Manually setting pargv = NULL gives dead code. Looks like it's unused anyway. Signed-off-by: Alexey Fomenko --- libbb/getopt32.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/libbb/getopt32.c b/libbb/getopt32.c index 25bae31..576d52f 100644 --- a/libbb/getopt32.c +

[PATCH 0/3] busybox fixes

2011-03-01 Thread Alexey Fomenko
Hello. Here are some patches fixing small resource leaks. Hope they will be useful. Alexey Fomenko (3): removed dead code. pargv was set NULL before cycle manually free allocated iface, liface and ifname before return Add missing fclose() libbb/getopt32.c |4 networking/ifup

Re: Ping

2011-03-01 Thread Bernd Petrovitsch
Hi! On Die, 2011-03-01 at 12:08 +0100, Harald Becker wrote: [...] > >> Is the mailing list down? ... please ignore, it's just a self test. > > Ever read https://www.kernel.org/pub/linux/docs/lkml/#s3-15? > > Did you read this: "please ignore, it's just a self test" ? Yes, and? Do you think it's

Re: Ping

2011-03-01 Thread Stuart Longland
On 03/01/11 21:08, Harald Becker wrote: > Hallo Bernd! > >>> Is the mailing list down? ... please ignore, it's just a self test. >> Ever read https://www.kernel.org/pub/linux/docs/lkml/#s3-15? > > Did you read this: "please ignore, it's just a self test" ? A "self" test to a mailing list that e

Re: Ping

2011-03-01 Thread Harald Becker
Hallo Bernd! >> Is the mailing list down? ... please ignore, it's just a self test. > Ever read https://www.kernel.org/pub/linux/docs/lkml/#s3-15? Did you read this: "please ignore, it's just a self test" ? -- Harald ___ busybox mailing list busybox@

Re: Ping

2011-03-01 Thread Bernd Petrovitsch
On Mon, 2011-02-28 at 13:09 +0100, Harald Becker wrote: > Is the mailing list down? ... please ignore, it's just a self test. Ever read https://www.kernel.org/pub/linux/docs/lkml/#s3-15? The same as for majordomo holds for mailman. Bernd -- Bernd Petrovitsch Email : be...@petro

Re: iplink_can support on Busybox

2011-03-01 Thread Hector Palacios
On 02/25/2011 05:13 PM, Palacios, Hector wrote: I need the 'ip' applet to support Socket-CAN devices. In iproute2 suite this is handled by iplink_can.c. Has anybody already tried to add this support to busybox? Could anybody tell if there is any plan to add CAN support to the 'ip' applet? Than