Re: [PATCH] udhcpc6 source address is null, should be link-local address

2013-08-21 Thread Ralf Friedl
Denys Vlasenko wrote: But what if interface has no IPv6 addresses? Isn't the whole purpose of DHCP is to *acquire an address*? For example, I don't use or need IPv6 for now. I just checked, and as expected, none of my interfaces have any IPv6 addresses. What should happen in this case? Does an

[PATCH] guess_fstype applet

2013-08-21 Thread James B
bb-1.22-aug2013-guess_fstype-applet.patch Description: Binary data ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

[PATCH] guess_fstype applet

2013-08-21 Thread James B
Sorry for the double post - previous email was sent in HTML mode. My apology. - klibc has "fstype" binary to detect filesystem types during boot time. util-linux mount has "mount -guess-fstype" to do the same. Busybox's volume_id detection is much more powerful than klibc's fstype, so I'm pr

Re: [PATCH] guess_fstype applet

2013-08-21 Thread Ralf Friedl
James B wrote: klibc has "fstype" binary to detect filesystem types during boot time. util-linux mount has "mount -guess-fstype" to do the same. Why not use printf? It's already used in busybox, so it wont be included just for this applet. I'm sure it would also make the code shorter. (I do hop

Re: [PATCH] guess_fstype applet

2013-08-21 Thread James B
ptimize out the calls to strlen for the constant > strings.) > > How about this: > char const *type; > if ((!volume_id_probe_all (id, 0)) && id->type) > type = id->type; > else { > type = "unknown"; > retcode = 1; > } > if (argc > 2)