Re: [PATCH] addgroup could assign already in use group

2015-02-07 Thread tito
Hi, just a ping. Ciao, Tito On Saturday 20 September 2014 16:45:14 tito wrote: > Hi, > while looking at the long username stuff and malloced getpwxx functions > I've noticed a bug in addgroup resulting in assignement of a wrong > (already in use) gid. In the function xgroup_study: > > static voi

Re: [PATCH] linedit, deluser: use POSIX getpwent instead of getpwent_r

2015-02-07 Thread Denys Vlasenko
You convinced me. I just committed a change which got rid of getpwent_r. Please try current git and let me know if I messed up. On Sat, Feb 7, 2015 at 6:54 PM, Rich Felker wrote: > On Sat, Feb 07, 2015 at 09:49:19AM -0800, Isaac Dunham wrote: >> On Thu, Feb 05, 2015 at 03:52:24PM -0500, Rich Fel

Re: Bug report: rmmod fails to a remove side-loaded module in Busybox 1.23

2015-02-07 Thread Denys Vlasenko
Please send me your .configs, and complete strace outputs of both rmmod invocations. On Fri, Feb 6, 2015 at 12:00 PM, AGATE Stephen wrote: > Fails with Busybox 1.23.1: > > /dev/shm # ls > fpgaint.ko > //dev/shm # insmod fpgaint.ko irq=135 > /dev/shm # lsmod > fpgaint 882 0 - Live 0xbf018000 (O) >

Re: [PATCH] libbb/loop: don't try to re-use existing loop device

2015-02-07 Thread Denys Vlasenko
Applied, thanks! On Wed, Feb 4, 2015 at 1:17 AM, Kevin Wallace wrote: > loopinfo.lo_file_name is not enough to uniquely identify a file on a system > with > multiple mount namespaces. We could conceivably change this to dedup on > (lo_rdevice, lo_inode), but, as the comment above the deleted co

Re: [PATCH] linedit, deluser: use POSIX getpwent instead of getpwent_r

2015-02-07 Thread Rich Felker
On Sat, Feb 07, 2015 at 09:49:19AM -0800, Isaac Dunham wrote: > On Thu, Feb 05, 2015 at 03:52:24PM -0500, Rich Felker wrote: > > On Thu, Feb 05, 2015 at 09:42:08PM +0100, Denys Vlasenko wrote: > > > struct passwd *getpwent() > > > { > > > static char *line; > > > static struct passw

Re: [PATCH] linedit, deluser: use POSIX getpwent instead of getpwent_r

2015-02-07 Thread Isaac Dunham
On Thu, Feb 05, 2015 at 03:52:24PM -0500, Rich Felker wrote: > On Thu, Feb 05, 2015 at 09:42:08PM +0100, Denys Vlasenko wrote: > > struct passwd *getpwent() > > { > > static char *line; > > static struct passwd pw; > > size_t size=0; > > if (!f) f = fopen("/etc/passw

Re: busybox-1.23.0-r1 does not set /dev/snd group properly

2015-02-07 Thread Denys Vlasenko
On Sat, Feb 7, 2015 at 4:32 PM, Felix Janda wrote: > With commit c3cf1e30a3022453311a7e9fe11d94c7a381640e the behavior > of mdev has changed. > > I had to change the line > > pcm.* root:audio 660 =snd/ > > in my mdev.conf to > > snd/pcm.* root:audio 660 > > since the device name is now tak

Re: [PATCH] linedit, deluser: use POSIX getpwent instead of getpwent_r

2015-02-07 Thread Rich Felker
On Sat, Feb 07, 2015 at 03:14:10PM +0100, Denys Vlasenko wrote: > On Sat, Feb 7, 2015 at 2:32 AM, Rich Felker wrote: > >> > the _r functions are for thread-safe > >> > versions of their corresponding legacy functions, but getpwent_r has > >> > inherent global state -- the iterator. Whoever made it

Re: Deluser: deleting the home folder

2015-02-07 Thread tito
On Saturday 07 February 2015 16:45:34 you wrote: > On Thu, Feb 5, 2015 at 9:03 PM, tito wrote: > > On Thursday 05 February 2015 19:48:47 Laszlo Papp wrote: > >> On Thu, Feb 5, 2015 at 6:41 PM, Denys Vlasenko > >> wrote: > >> > On Thu, Feb 5, 2015 at 6:49 PM, Laszlo Papp wrote: > >> >> I think i

Re: Deluser: deleting the home folder

2015-02-07 Thread Denys Vlasenko
On Thu, Feb 5, 2015 at 9:03 PM, tito wrote: > On Thursday 05 February 2015 19:48:47 Laszlo Papp wrote: >> On Thu, Feb 5, 2015 at 6:41 PM, Denys Vlasenko >> wrote: >> > On Thu, Feb 5, 2015 at 6:49 PM, Laszlo Papp wrote: >> >> I think it is bad idea to only allow this operation when long options

Re: busybox-1.23.0-r1 does not set /dev/snd group properly

2015-02-07 Thread Felix Janda
With commit c3cf1e30a3022453311a7e9fe11d94c7a381640e the behavior of mdev has changed. I had to change the line pcm.* root:audio 660 =snd/ in my mdev.conf to snd/pcm.* root:audio 660 since the device name is now taken directly from the uevent file (changing from pcmC0D0c to snd/pcmC0D0

Re: [PATCH] linedit, deluser: use POSIX getpwent instead of getpwent_r

2015-02-07 Thread Denys Vlasenko
On Sat, Feb 7, 2015 at 3:48 PM, tito wrote: >> char *line=0; >> size_t size=0; >> if (!f) f = fopen("/etc/passwd", "rbe"); >> if (!f) return 0; > Hi, > this should return ENOENT You are correct. > >> *pwbufp = __getpwent_a(f, pwbuf, &line, &size); >>

Re: [PATCH] linedit, deluser: use POSIX getpwent instead of getpwent_r

2015-02-07 Thread tito
On Saturday 07 February 2015 15:14:10 Denys Vlasenko wrote: > On Sat, Feb 7, 2015 at 2:32 AM, Rich Felker wrote: > >> > the _r functions are for thread-safe > >> > versions of their corresponding legacy functions, but getpwent_r has > >> > inherent global state -- the iterator. Whoever made it jus

Re: [PATCH] linedit, deluser: use POSIX getpwent instead of getpwent_r

2015-02-07 Thread Denys Vlasenko
On Sat, Feb 7, 2015 at 2:32 AM, Rich Felker wrote: >> > the _r functions are for thread-safe >> > versions of their corresponding legacy functions, but getpwent_r has >> > inherent global state -- the iterator. Whoever made it just wasn't >> > thinking. To make a correct interface like this the ca