$((fail++)) is not a required expression in POSIX, and in "dash" it
could produce an error like this:
./make_single_applets.sh: 61: arithmetic expression: expecting primary:
"fail++"
Replace this with something portable: fail=$((fail+1)) would work.
Signed-off-by: Kang-Che Sung
Building Busybox on SPARC or SPARC64 with CONFIG_BUILD_LIBBUSYBOX=y
currently fails with:
miscutils/lib.a(i2c_tools.o): In function `i2c_dev_open':
i2c_tools.c:(.text.i2c_dev_open+0x14): relocation truncated to fit:
R_SPARC_GOT13 against `.LC0'
i2c_tools.c:(.text.i2c_dev_open+0x38): relocation
Makefile.flags contains:
ARCH_FPIC ?= -fpic
ARCH_FPIE ?= -fpie
However, arch/$(ARCH)/Makefile gets included *after* Makefile.flags,
and therefore doesn't get the chance to provide its own value.
Fix this by including arch/$(ARCH)/Makefile *before* Makefile.flags.
Signed-off-by: Thomas
It would appear that some compile-time flags are used as if they were
runtime flags, i.e. they are used in if (...) constructs, not in
`#if ... #endif` guards.
The effect *should* be the same, except when switching off optimization
(e.g. for debugging) where dead code is not removed, possibly
In 4c1392296 (Introduce FEATURE_COPYBUF_KB, 2007-12-02), a feature was
introduced where a large stack was allocated via mmap(), and
consequently released via munmap(). Since this is overkill for small
stacks, the mmap()/munmap() code was guarded inside an #if
CONFIG_FEATURE_COPYBUF_KB > 4 ...
Using the constant in a regular `if (...)` pretends that this is
anything but a compile time option. Let's use `#if JOBS` instead,
making it *much* clearer what `JOBS` actually is.
Incidentally, this change fixes the build in setups where there are
no headers defining WIFSTOPPED and WSTOPSIG
Hi Denys,
On Fri, 14 Jul 2017, Denys Vlasenko wrote:
> On Fri, Jul 14, 2017 at 4:11 PM, Johannes Schindelin
> wrote:
> > In 4c1392296 (Introduce FEATURE_COPYBUF_KB, 2007-12-02), a feature was
> > introduced where a large stack was allocated via mmap(), and
> >
Hi Denys,
On Fri, 14 Jul 2017, Denys Vlasenko wrote:
> On Fri, Jul 14, 2017 at 4:11 PM, Johannes Schindelin
> wrote:
> > Using the constant in a regular `if (...)` pretends that this is
> > anything but a compile time option. Let's use `#if JOBS` instead,
> > making
Hi Xabier,
On Fri, 14 Jul 2017, Xabier Oneca -- xOneca wrote:
> 2017-07-14 16:11 GMT+02:00 Johannes Schindelin :
> > @@ -4182,7 +4186,9 @@ dowait(int block, struct job *job)
> > goto out;
> > }
> > /* The process wasn't found in job
does anyone know if it's possible to run multipathd under busybox? i
suspect this is a fools errand given that multipath is a redhat
project, which then ties it with udev which then ties it with systemd.
i tried just grabbing the multipath binaries from rhel7 and plugging
them into my initrd
On Fri, Jul 14, 2017 at 4:11 PM, Johannes Schindelin
wrote:
> This flag is used in #if ... #endif guards elsewhere and there is no
> good reason to pretend that it is a runtime flag in just one case.
>
> This probably was an oversight in a61cb92f2 (make /etc/network
On Fri, Jul 14, 2017 at 4:11 PM, Johannes Schindelin
wrote:
> In 4c1392296 (Introduce FEATURE_COPYBUF_KB, 2007-12-02), a feature was
> introduced where a large stack was allocated via mmap(), and
> consequently released via munmap(). Since this is overkill for small
>
On Fri, Jul 14, 2017 at 4:11 PM, Johannes Schindelin
wrote:
> Using the constant in a regular `if (...)` pretends that this is
> anything but a compile time option. Let's use `#if JOBS` instead,
> making it *much* clearer what `JOBS` actually is.
>
> Incidentally, this
Hello Johannes,
2017-07-14 16:11 GMT+02:00 Johannes Schindelin :
> Using the constant in a regular `if (...)` pretends that this is
> anything but a compile time option. Let's use `#if JOBS` instead,
> making it *much* clearer what `JOBS` actually is.
>
> Incidentally,
Nevermind. I ended up figuring it out. Granted it's not for BB, but
just as a follow-up if anyone comes across this thread they will have
what I came up with:
find /tmp/test -type f \( -name \*.typelib -o -name \*.gir \) -exec
/bin/sh -c 'TEMP="${1#*/}"; mkdir -p "${0}/${TEMP%/*}" 2>/dev/null;
In 4c1392296 (Introduce FEATURE_COPYBUF_KB, 2007-12-02), a feature was
introduced where a large stack was allocated via mmap(), and
consequently released via munmap(). Since this is overkill for small
stacks, the mmap()/munmap() code was guarded inside an #if
CONFIG_FEATURE_COPYBUF_KB > 4 ...
Using the constant in a regular `if (...)` pretends that this is
anything but a compile time option. Let's use `#if JOBS` instead,
making it *much* clearer what `JOBS` actually is.
Incidentally, this change fixes the build in setups where there are
no headers defining WIFSTOPPED and WSTOPSIG
This flag is used in #if ... #endif guards elsewhere and there is no
good reason to pretend that it is a runtime flag in just one case.
This probably was an oversight in a61cb92f2 (make /etc/network parsing
configurable. -200 bytes when off., 2007-06-19).
Besides, it fixes a compile problem on
It would appear that some compile-time flags are used as if they were
runtime flags, i.e. they are used in if (...) constructs, not in
`#if ... #endif` guards.
The effect *should* be the same, except when switching off optimization
(e.g. for debugging) where dead code is not removed, possibly
Oops! It does appear that I was using GNU find, not BB. Sorry about
that. Any thoughts on how this can be done without execdir then using
BB find?
Thanks,
Dave
On 7/14/17, Denys Vlasenko wrote:
> On Thu, Jul 13, 2017 at 11:52 PM, David Henderson
>
On Thu, Jul 13, 2017 at 11:52 PM, David Henderson
wrote:
> Good evening all! I am trying to move files from one location to
> another while preserving the path. If I search for a directory, it
> seems like I have found the correct syntax:
>
> find
Applied, thanks
On Thu, Jul 13, 2017 at 3:35 PM, Kang-Che Sung wrote:
> When these options were introduced in d88f94a5df3a2edb8ba56fab5c13674b452f87ab
> it provides no config options to compile them out. Now provide one.
>
> Introduce config FEATURE_CATN.
>
> Signed-off-by:
Avoid dereferencing 'don_add' in strcmp since it is invalid
pointer.
Signed-off-by: Timo Teräs
---
Please include in -fixes for v1.27.0
loginutils/add-remove-shell.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/loginutils/add-remove-shell.c
23 matches
Mail list logo