Re: [PATCH 2/2] i2c-tools: fix build with upstream i2c-tools' headers

2017-08-28 15:52 GMT+02:00 Bartosz Gołaszewski : > 2017-08-28 15:48 GMT+02:00 Denys Vlasenko : >> On Mon, Aug 28, 2017 at 11:49 AM, Bartosz Golaszewski >> wrote: >>> Installing headers from upstream i2c-tools makes it impossible to >>> build the busybox version due to redefined symbols. This is ca

Re: [PATCH 2/2] i2c-tools: fix build with upstream i2c-tools' headers

2017-08-28 11:49 GMT+02:00 Bartosz Golaszewski : > Installing headers from upstream i2c-tools makes it impossible to > build the busybox version due to redefined symbols. This is caused by > the fact that linux/i2c-dev.h from i2c-tools overwrites the one from > linux uapi and defines symbols alread

[PATCH] i2c-tools: don't include linux/i2c-dev.h

Installing headers from upstream i2c-tools makes it impossible to build the busybox version due to redefined symbols. This is caused by the fact that linux/i2c-dev.h from i2c-tools overwrites the one from linux uapi and defines symbols already defined by linux' linux/i2c.h. Drop this include and s

Re: [PATCH 2/2] i2c-tools: fix build with upstream i2c-tools' headers

2017-08-28 15:48 GMT+02:00 Denys Vlasenko : > On Mon, Aug 28, 2017 at 11:49 AM, Bartosz Golaszewski > wrote: >> Installing headers from upstream i2c-tools makes it impossible to >> build the busybox version due to redefined symbols. This is caused by >> the fact that linux/i2c-dev.h from i2c-tools

Re: [PATCH 2/2] i2c-tools: fix build with upstream i2c-tools' headers

On Mon, Aug 28, 2017 at 11:49 AM, Bartosz Golaszewski wrote: > Installing headers from upstream i2c-tools makes it impossible to > build the busybox version due to redefined symbols. This is caused by > the fact that linux/i2c-dev.h from i2c-tools overwrites the one from > linux uapi and defines s

Re: [PATCH 1/2] i2c-tools: remove unneeded include

Applied, thanks! On Mon, Aug 28, 2017 at 11:49 AM, Bartosz Golaszewski wrote: > We no longer use common_bufsiz1 in i2c-tools. > > Don't include common_bufsiz.h. > > Signed-off-by: Bartosz Golaszewski > --- > miscutils/i2c_tools.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/miscutils

Re: [PATCH] kill: add '--' option to separate options from arguments

Applied, thanks. On Sun, Aug 27, 2017 at 9:25 AM, Ron Yorston wrote: > Using a negative pid to send TERM to a process group results in an > obscure error: > >$ ./busybox kill -12345 >kill: bad signal name '12345' > > There are a couple of workarounds: > > - specify the signal: 'kill -TERM

Re: [PATCH 1/1] xargs: support -P (parallel execution)

On Fri, Aug 25, 2017 at 1:56 PM, Johannes Schindelin wrote: >> { >> int status; >> >> +#if !ENABLE_FEATURE_XARGS_SUPPORT_PARALLEL >> status = spawn_and_wait(G.args); >> +#else >> +if (G.max_procs == 1) { >> +status = spawn_and_wait(G.args); >> +} else { >> +pid_t

[PATCH 0/2] i2c-tools fixes

Two patches for i2c-tools: one minor - just removing an unnecessary include - and one fixing a significant bug: building busybox' i2c-tools with upstream i2c-tools headers installed. Bartosz Golaszewski (2): i2c-tools: remove unneeded include i2c-tools: fix build with upstream i2c-tools' heade

[PATCH 2/2] i2c-tools: fix build with upstream i2c-tools' headers

Installing headers from upstream i2c-tools makes it impossible to build the busybox version due to redefined symbols. This is caused by the fact that linux/i2c-dev.h from i2c-tools overwrites the one from linux uapi and defines symbols already defined by linux' linux/i2c.h. Fix it by including lin

[PATCH 1/2] i2c-tools: remove unneeded include

We no longer use common_bufsiz1 in i2c-tools. Don't include common_bufsiz.h. Signed-off-by: Bartosz Golaszewski --- miscutils/i2c_tools.c | 1 - 1 file changed, 1 deletion(-) diff --git a/miscutils/i2c_tools.c b/miscutils/i2c_tools.c index 30f606e8e..03a09d519 100644 --- a/miscutils/i2c_tools.