Re: [PATCH] Add a 'busybox --list name' option to display script content Re: License concerns when embedding script in busybox binary

2018-11-09 Thread Kang-Che Sung
On Sat, Nov 10, 2018 at 2:10 AM Ron Yorston wrote: > > Add an option to allow the content of embedded scripts to be > displayed. > > It's disabled by default. When enabled: > > function old new delta > run_applet_and_exit

Re: [PATCH] Add a 'busybox --list name' option to display script content Re: License concerns when embedding script in busybox binary

2018-11-09 Thread Tito
Hi, I'am speechless... but we still need an option to colorize the output ;-) Ciao, Tito On 09/11/18 19:10, Ron Yorston wrote: Add an option to allow the content of embedded scripts to be displayed. It's disabled by default. When enabled: function

Re: [RFC PATCH v2] Allow applets to be implemented as scripts

2018-11-09 Thread Ron Yorston
Eli Schwartz wrote: >If you absolutely must provide these scripts, move them to docs/ -- >including nologin -- which is more descriptive of their initial >intention. applets_sh/README says: So far these scripts are not hooked to the build system and are not installed by "make install".

[PATCH] Add a 'busybox --list name' option to display script content Re: License concerns when embedding script in busybox binary

2018-11-09 Thread Ron Yorston
Add an option to allow the content of embedded scripts to be displayed. It's disabled by default. When enabled: function old new delta run_applet_and_exit 728 801 +73 .rodata

Re: License concerns when embedding script in busybox binary

2018-11-09 Thread Ron Yorston
Michael Conrad wrote: >Maybe if >busybox had an option to dump out the scripts it would help enforce the >idea that the sources were being shipped.  Wonder how many bytes that >would require... 122, apparently. $ make bloatcheck function old new

Re: [RFC PATCH v2] Allow applets to be implemented as scripts

2018-11-09 Thread Eli Schwartz
On 11/7/18 2:42 AM, Ron Yorston wrote: > Kang-Che Sung wrote: >> Let no script applets individually configurable in menuconfig. Let users >> resolve the dependencies of whatever they put in applets_sh. > > My view is that if script applets are provided as part of BusyBox they > should have all

Re: [RFC PATCH v2] Allow applets to be implemented as scripts

2018-11-09 Thread Michael Conrad
On 11/7/2018 9:18 AM, Kang-Che Sung wrote: On Wed, Nov 7, 2018 at 9:54 PM Tito wrote: this embedded scripts patch looks like "featuritis" at its best to me. It is adding complexity for solving what problem exactly: avoiding to copy the scripts manually to the new system or to the new firmware

Re: License concerns when embedding script in busybox binary

2018-11-09 Thread Michael Conrad
On 11/7/2018 10:49 AM, Ron Yorston wrote: Kang-Che Sung wrote: Specifically, I think the current state of config ASH_EMBEDDED_SCRIPTS help text did not yet warn builders that the binary may be distributed **only when the embedding scripts are GPLv2-compatible**. Builder and distributors may

[PATCH 1/3 v2] Support both custom scripts and scripted applets

2018-11-09 Thread Ron Yorston
BusyBox has support for embedded shell scripts. Two types can be distinguished: custom scripts and scripts implementing applets. All embedded scripts can be run by name and are subject to tab completion in standalone shell mode. Custom scripts are otherwise unsupported by BusyBox and are

[PATCH] hush: correct description for HUSH_TICK config option

2018-11-09 Thread Ron Yorston
The HUSH_TICK configuration option enables command substitution, not process substitution. Signed-off-by: Ron Yorston --- shell/hush.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shell/hush.c b/shell/hush.c index 881331c5b..431010f09 100644 --- a/shell/hush.c +++

[PATCH 3/3] Allow a profile script to be embedded in the binary

2018-11-09 Thread Ron Yorston
If the file embed/.profile exists at build time it is placed at the start of the block of compressed scripts. Its name isn't included in the list of scripts so it can't be run directly by the user. Instead it is executed when a login shell is started, before /etc/profile. With no embed/.profile

[PATCH 2/3] Add 'busybox --scripts' option to list custom scripts

2018-11-09 Thread Ron Yorston
Instead of listing custom scripts along with applets add an option to list them separately. This emphasizes their special status as not fully supported by BusyBox. With no custom scripts the size of the binary is unchanged; with an empty custom script: function

[PATCH 1/3] Support both custom scripts and scripted applets

2018-11-09 Thread Ron Yorston
BusyBox has support for embedded shell scripts. Two types can be distinguished: custom scripts and scripts implementing applets. All embedded scripts can be run by name and are subject to tab completion in standalone shell mode. Custom scripts are otherwise unsupported by BusyBox and are

[PATCH 0/3] Support both custom scripts and scripted applets

2018-11-09 Thread Ron Yorston
I've been continuing to tinker with embedded scripts. The following series replaces all previous uncommitted patches. - handling of scripted applets has been reworked to avoid having to store duplicate copies of their names: their applet number is used to find their scripts; - the nologin