Re: [PATCH] domain_codec: optimize call to dname_enc

On Thu, 11 Jun 2020 13:12:53 -0500 Martin Lewis wrote: > Hi, > Yes, looks good :) PS: i was at first a bit thrown off by the function name to talk about DNAME RR (as opposed to CNAME RR resp. domain_name) but in the context of dhcp as opposed to dns it makes more sense i suppose. I'd expand the

Re: [git commit] Makefile.flags: restrict Wno-constant-logical-operand and Wno-string-plus-int options for clang

On 10 June 2020 14:33:19 CEST, Denys Vlasenko wrote: >commit: >https://git.busybox.net/busybox/commit/?id=505eeae402a84dc5208986c5ad611f5e485cbe34 >branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master > >these options were added in b4ef2e3467d8e980ccf13c9dd342459c013b455f >commit >

IPv6 - DHCPv6 [PATCH]

Hi all, as Martin suggests, I here have my changes in a way like most Patches are in the mailing list... I did not push them to Git because I think I have no rights...The changes cause the multicast message now to be received by the Server. Still the answer seems to have no effect to the dhcpc6

Re: [PATCH] domain_codec: optimize call to dname_enc

Hi, Yes, looks good :) Martin On Wed, 10 Jun 2020 at 10:21, Denys Vlasenko wrote: > Thanks. I addressed this a bit differently. Looks good now? > > On Tue, Jun 9, 2020 at 4:55 PM Martin Lewis > wrote: > > > > The only call to dname_enc is with cstr = NULL, so most of dname_enc's > logic is not

Re: [PATCH] domain_codec: optimize call to dname_enc

Thanks. I addressed this a bit differently. Looks good now? On Tue, Jun 9, 2020 at 4:55 PM Martin Lewis wrote: > > The only call to dname_enc is with cstr = NULL, so most of dname_enc's logic > is not used. > Therefore, we can directly call convert_dname and shrink the binary size. > > function