Re: [PATCH] shrink last_char_is function even more

2020-07-19 Thread Lauri Kasanen
On Sun, 19 Jul 2020 22:31:09 +0200 Tito wrote: > please don't do this, this will bite us further up the road, > similarly as all string functions that save a check and break > havoc afterwards. The param should be marked with the nonnull attribute, just like the libc string functions. Then the

Re: [PATCH] shrink last_char_is function even more

2020-07-19 Thread Michael Conrad
On 7/19/2020 2:48 PM, Denys Vlasenko wrote: strrchr(s,c) will first find the end of s, then go backwards looking for c. The second part is wasted work, we only need to check the*last* char == c. Maybe a naive implementation, but why wouldn't they just record the last occurrence on a forward

Re: [PATCH] shrink last_char_is function even more

2020-07-19 Thread Tito
On 7/19/20 8:48 PM, Denys Vlasenko wrote: > On Tue, Jul 7, 2020 at 9:17 PM Tito wrote: >> Hi, >> attached you will find a patch that shrinks libbb's last_char_is function. >> bloatcheck is: >> >> function old new delta >> last_char_is

Re: How unstable is busybox "unstable"?

2020-07-19 Thread Denys Vlasenko
On Tue, Jul 14, 2020 at 4:53 PM Tim Tassonis wrote: > Hi all > > I just saw that busybox 1.32.0 is out, including the find "-empty" > extension by Aaro Koskinen, which is a really great addition for me, in > order to remove deeply-nested directory structures, when empty (kernel > modules

Re: [PATCH] Support for ftp PASV responses not ending with ')'

2020-07-19 Thread Denys Vlasenko
Applied, thanks! On Sun, Jul 12, 2020 at 9:34 PM Baruch Burstein wrote: > > --- > networking/parse_pasv_epsv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/networking/parse_pasv_epsv.c b/networking/parse_pasv_epsv.c > index 14f4d4258..de4032612 100644 > ---

Re: [PATCH] shrink last_char_is function even more

2020-07-19 Thread Denys Vlasenko
On Tue, Jul 7, 2020 at 9:17 PM Tito wrote: > Hi, > attached you will find a patch that shrinks libbb's last_char_is function. > bloatcheck is: > > function old new delta > last_char_is 53 42 -11 >

Re: [PATCH] shrink last_char_is function even more

2020-07-19 Thread Denys Vlasenko
On Thu, Jul 16, 2020 at 7:53 AM Stefan Seyfried wrote: > > Am 09.07.20 um 21:13 schrieb Tito: > > On 7/9/20 9:56 PM, Martin Lewis wrote: > >> Please note that my original patch is still smaller: > >> http://lists.busybox.net/pipermail/busybox/2020-June/088026.html > > > > Hi, > > yes I know. This