Hi! I'm attaching a color log of some spots that may benefit of using narrower return types; See "could return".
It certainly misses still quite some cases as it currently works only per function and thus does not see return values flowing from calls in the function. Taking call's known return ranges into account would point at e.g. pack_lzop() which returns 1 always. I guess most if not all of the spots noting that "Maybe the function should be ‘void’" are not that useful to mention, but i included them here anyway. In BusyBox we have alot of *_main and i currently only ignore main()s return value.. And JFYI i did only spot-check a few places, not all. Hope this is useful. cheers,
LOG-color.02.txt.gz
Description: application/gzip
_______________________________________________ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
