Re: Tar component in busybox version 1.34.1 has a memory leak bug when trying to unpack a tar file.

2021-12-01 Thread Laurent Bercot
A stock Linux system will happily slaughter your system services with the OOM killer before malloc ever returns NULL. Only if overcommit is activated, which is not a good idea in embedded systems where busybox is likely to be used. Also, resource limits are a thing, and proper administration

Re: Tar component in busybox version 1.34.1 has a memory leak bug when trying to unpack a tar file.

2021-12-01 Thread Michael Conrad
On 12/1/21 7:42 AM, tito wrote: It can matter: consider large tar files on memory constrained devices. tar may fail to complete correctly, due to running out of memory, and in the process of running out of memory, may invoke the OOM killer in the process, which might kill some other process.

Re: Tar component in busybox version 1.34.1 has a memory leak bug when trying to unpack a tar file.

2021-12-01 Thread tito
On Wed, 1 Dec 2021 03:41:21 -0600 (CST) Ariadne Conill wrote: > Hi, > > On Wed, 1 Dec 2021, David Laight wrote: > > > From: busybox On Behalf Of Ping Lee > >> Sent: 01 December 2021 01:42 > > > >> It seems that I found a bug on busybox version 1.34.1: > >> In libbb/xfuncs_printf.c:50, malloc

RE: Tar component in busybox version 1.34.1 has a memory leak bug when trying to unpack a tar file.

2021-12-01 Thread Ariadne Conill
Hi, On Wed, 1 Dec 2021, David Laight wrote: From: busybox On Behalf Of Ping Lee Sent: 01 December 2021 01:42 It seems that I found a bug on busybox version 1.34.1: In libbb/xfuncs_printf.c:50, malloc twice for archive_handle and archive_hadle->fileheader with 184 and 72 bytes heap space.

RE: Tar component in busybox version 1.34.1 has a memory leak bug when trying to unpack a tar file.

2021-12-01 Thread David Laight
From: busybox On Behalf Of Ping Lee > Sent: 01 December 2021 01:42 > It seems that I found a bug on busybox version 1.34.1: > In libbb/xfuncs_printf.c:50, malloc twice for archive_handle and > archive_hadle->fileheader with 184 and 72 bytes heap space. > Back to tar_main function, the two >