Re: [PATCH] ash: fix use-after-free in bash pattern substitution

2022-08-02 Thread Denys Vlasenko
Applied, thank you. On Tue, Aug 2, 2022 at 5:58 PM Sören Tempel wrote: > > PING again :) > > Sören Tempel wrote: > > PING. > > > > This has been applied at Alpine Linux downstream for the past few months > > and we didn't encounter into any issues with this particular patch so far. > > > >

Re: [PATCH] ash: fix use-after-free in bash pattern substitution

2022-08-02 Thread Sören Tempel
PING again :) Sören Tempel wrote: > PING. > > This has been applied at Alpine Linux downstream for the past few months > and we didn't encounter into any issues with this particular patch so far. > > soe...@soeren-tempel.net wrote: > > From: Sören Tempel > > > > At Alpine Linux downstream,

Re: udhcpc6 kernel listen mode is broken

2022-08-02 Thread Denys Vlasenko
Fixed, thank you. Can you try current git? On Sat, Jun 4, 2022 at 2:58 AM Danomi Manchego wrote: > > Sorry all, I did not realize that there was a function called > d6_listen_socket() in d6_socket.c - so no new function is needed to > fix DHCPv6 Renew reply processing. The correct message ID is

Re: [PATCH] vi: add 'ZQ' quitting command

2022-08-02 Thread Denys Vlasenko
Applied, thank you On Wed, Jun 8, 2022 at 9:52 PM Grob Grobmann wrote: > > Busybox vi provides the 'ZZ' command to save and close > the similar 'ZQ' command just exits without saving > I propose this small patch to add that command. > > diff --git a/editors/vi.c b/editors/vi.c > index

Re: [PATCH] ping: fix typo

2022-08-02 Thread Denys Vlasenko
Applied, thank you On Mon, Aug 1, 2022 at 2:22 PM Henrique Rodrigues wrote: > > Hi, > > Please finx attached a patch that fixes two typos on networking/ping.c. > "recevied" should be "received". > > Thank you, > Henrique Rodrigues > ___ > busybox

Re: [PATCH v2] ash: Fix use-after-free on idx variable

2022-08-02 Thread Denys Vlasenko
Applied, thank you. On Wed, Jun 1, 2022 at 4:18 PM wrote: > > From: Sören Tempel > > Consider the following code from ash.c: > > STPUTC(*idx, expdest); > if (quotes && (unsigned char)*idx == CTLESC) { > > The idx variable points to a value in the stack string (as managed > by

Re: [PATCHv3]ash: Add ifsfree to varunset and varvalue function to fix a buffer over-read

2022-08-02 Thread Denys Vlasenko
Applied, thank you! On Mon, Jun 20, 2022 at 8:23 PM Alex Gorinson wrote: > > Due to a logic error in the ifsbreakup function in ash.c when a > heredoc and normal command is run one after the other by means of a > semi-colon, when the second command drops into ifsbreakup the command > will be