Re: [PATCH v4] readlink: slight size optimization

2023-04-24 Thread David Leonard
On Mon, 24 Apr 2023, Harald van Dijk wrote: coreutils/readlink.c:91:27: warning: adding 'unsigned int' to a string does not append to the string [-Wstring-plus-int] printf("%s%s", buf, "\n" + (opt & 1)); ~^~~ coreutils/readlink.c:91:27: note: use

Re: [PATCH v4] readlink: slight size optimization

2023-04-24 Thread Harald van Dijk
On 18/04/2023 13:22, Eric Blake wrote: Exploit the value of the flag for -n to reduce the size of readlink_main() (regardless of the value of CONFIG_FEATURE_READLINK_FOLLOW) on x86_64. function old new delta readlink_main