Re: incorrect -a flag in busybox tar (creation mode)?

2019-08-02 Thread Denys Vlasenko
Fixed in git, thanks On Wed, Jul 24, 2019 at 9:33 AM David Demelier wrote: > > Le 24/07/2019 à 09:22, David Demelier a écrit : > > Hello, > > > > I've discovered that busybox tar -a flag acts differently than both > > bsdtar and GNU tar. If the archive ends with extension .txz it creates a > >

Re: [PATCH] ash: only catch unexpected exceptions in PS1 expansion

2019-07-31 Thread Denys Vlasenko
Applied, thanks! On Mon, Jul 29, 2019 at 11:00 AM Ron Yorston wrote: > > Commit d1a2fa2a4 (ash: catch error in arithmetic expansion in PS1) > catches all exceptions raised by expandarg(). Some exceptions, such as > the EXEXIT raised when command expansion is used, are expected: > >export

Re: 1.30.1 [ntpd] - not able to query

2019-07-03 Thread Denys Vlasenko
On Wed, Jul 3, 2019 at 12:02 PM wrote: > On 03/07/2019 11:55, Denys Vlasenko wrote: > > On Tue, Jul 2, 2019 at 3:20 PM wrote: > >> On 02/07/2019 15:07, Denys Vlasenko wrote: > >>>> Or won't fix and the ntpd implementation in busybox is not suited to act &g

Re: 1.30.1 [ntpd] - not able to query

2019-07-03 Thread Denys Vlasenko
On Tue, Jul 2, 2019 at 3:20 PM wrote: > On 02/07/2019 15:07, Denys Vlasenko wrote: > >> Or won't fix and the ntpd implementation in busybox is not suited to act > >> as server? > > > > It does act as server - you can query time from it and syncronize with

Re: 1.30.1 [ntpd] - not able to query

2019-07-02 Thread Denys Vlasenko
On Tue, Jul 2, 2019 at 2:42 PM wrote: > On 02/07/2019 14:36, Denys Vlasenko wrote: > > On Tue, Jul 2, 2019 at 12:03 PM wrote: > >> On 02/07/2019 11:26, Denys Vlasenko wrote: > >>> On Mon, Jul 1, 2019 at 3:09 PM wrote: > >>>> On 01/07/2019 12:51,

Re: 1.30.1 [ntpd] - not able to query

2019-07-02 Thread Denys Vlasenko
On Tue, Jul 2, 2019 at 12:03 PM wrote: > > On 02/07/2019 11:26, Denys Vlasenko wrote: > > On Mon, Jul 1, 2019 at 3:09 PM wrote: > >> On 01/07/2019 12:51, Denys Vlasenko wrote: > >>> On Sat, Jun 29, 2019 at 4:12 PM wrote: > >>>> ntpd appears to be

Re: [PATCH] libbb: reduce the overhead of single parameter bb_error_msg() calls

2019-07-02 Thread Denys Vlasenko
Applied, thanks! On Thu, Jun 27, 2019 at 11:52 AM James Byrne wrote: > > Hi, > > I sent a first version of this patch in May 2018, but the comment from > Denys in his reply on May 11, 2018 was that he didn't like the magic > macros I had used to automatically substitute different versions of >

Re: 1.30.1 [ntpd] - not able to query

2019-07-02 Thread Denys Vlasenko
On Mon, Jul 1, 2019 at 3:09 PM wrote: > > On 01/07/2019 12:51, Denys Vlasenko wrote: > > On Sat, Jun 29, 2019 at 4:12 PM wrote: > >> ntpd appears to be up and running/listening > >> > >> ss -tulpn | grep 123 > >> udp UNCONN 0 0*:123 *:*

Re: 1.30.1 [ntpd] - not able to query

2019-07-01 Thread Denys Vlasenko
On Sat, Jun 29, 2019 at 4:12 PM wrote: > > ntpd appears to be up and running/listening > > ss -tulpn | grep 123 > udp UNCONN 0 0*:123 *:* users:(("ntpd",pid=7589,fd=3)) > > However, querying the server appears not working, as if queries being > refused and thus wondering what could be

Re: [PATCH] free: include SReclaimable in cached value

2019-06-25 Thread Denys Vlasenko
Applied, thanks! On Sat, Jun 22, 2019 at 3:43 AM Lukas Rusak wrote: > > Is someone available to acknowledge this? Thanks! > > On Mon, Jun 10, 2019 at 14:35 Lukas Rusak wrote: >> >> I noticed that the 'used' values from busybox free and >> procps-ng free differed so I looked into why. It turns

Re: [PATCH 1/1] pidof - add option -q (quiet)

2019-06-20 Thread Denys Vlasenko
Not compatible with procps-ng 3.3.15 Which version of pidof has this option? On Tue, Jun 18, 2019 at 7:03 PM walter harms wrote: > > when used in a script no output is needed. The latest version > of pidof supports the -q option to make thinks more easy. > > Signed-off-by: walter > --- > I did

Re: Patch: use BB_GLOBAL_CONST where applicable

2019-06-18 Thread Denys Vlasenko
On Mon, Jun 17, 2019 at 2:30 PM Luís Marques wrote: > > On Thu, Jun 6, 2019 at 7:19 PM Denys Vlasenko > wrote: > > Can you experiment with LLVM and find a definition of SET_PTR_TO_GLOBALS() > > which works for it? > > I did not find any correct solution fo

Re: Using 'pidof' with Absolute Path to Process

2019-06-15 Thread Denys Vlasenko
On Tue, Jun 11, 2019 at 8:07 PM Marc Smith wrote: > Hi, > > We previously used Busybox 1.26.2 in our project and just recently > upgraded to Busybox 1.30.1. I noticed a change in the 'pidof' > behavior... previously we could give the absolute path of a running > program to 'pidof' and it would

Re: [PATCH] dhcpc.c: Added support for relay server parameter.

2019-06-11 Thread Denys Vlasenko
applied, thanks On Mon, Jun 10, 2019 at 5:07 PM Martin Lewis wrote: > > Resolved a TODO by adding support for gateway_nip parameter. > > Signed-off-by: Martin Lewis > --- > networking/udhcp/dhcpc.c | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH] ifupdown: Use recursive_action for "source-directory"

2019-06-09 Thread Denys Vlasenko
This causes growth: function old new delta read_interfaces_action - 84 +84 max_depth_one - 14 +14 read_interfaces 1241

Re: [PATCH] losetup/mount: Revise to use /dev/loop-control and thereby fix 'losetup -f'.

2019-06-09 Thread Denys Vlasenko
Looks too big. Please try current git, it has a smaller version. Please describe unwanted behavior (which you are fixing) more clearly On Tue, Mar 5, 2019 at 12:06 PM Nicolas Hüppelshäuser wrote: > > Fixed 'losetup -f' and 'losetup -f ' issue > = >

Re: [PATCH] start-stop-daemon: change priority before dropping privileges

2019-06-09 Thread Denys Vlasenko
applied, thanks! On Thu, Mar 7, 2019 at 10:23 AM Aitor Esteve Alvarado wrote: > > Currently start-stop-daemon fails when using both the -c option (set > uid) and -N option (set niceness/priority) as it first drops privileges > and then tries to increase the priority. This patch changes the order

Re: [PATCH] tftp: introduce CONFIG_FEATURE_TFTP_UMASK

2019-06-09 Thread Denys Vlasenko
Imagining myself in the situation where I need to download executables over tftp, the first solution which comes to mind is to just chmod them after download. Why that does not work for you? On Tue, Apr 30, 2019 at 8:07 PM Markus Mayer wrote: > > On Tue, 30 Apr 2019 at 10:22, Markus Mayer

Re: [PATCH] Add svg to built in MIME types list

2019-06-07 Thread Denys Vlasenko
applied, thanks On Thu, Jun 6, 2019 at 5:42 PM Vicente Jiménez wrote: > > Signed-off-by: Vicente Jimenez Aguilar > --- > networking/httpd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/networking/httpd.c b/networking/httpd.c > index 3f1e02ec8..b09ac0a2f 100644 > ---

Re: [PATCH] lpd: fix null pointer dereferencing on EOF

2019-06-07 Thread Denys Vlasenko
applied, thanks On Thu, Jun 6, 2019 at 2:06 PM Luís Marques wrote: > > This one fixes a crash if you run busybox lpd < /dev/null > > diff --git a/printutils/lpd.c b/printutils/lpd.c > index ce5944026..408695f39 100644 > --- a/printutils/lpd.c > +++ b/printutils/lpd.c > @@ -133,6 +133,8 @@ int

Re: Patch: use BB_GLOBAL_CONST where applicable

2019-06-06 Thread Denys Vlasenko
On Wed, Jun 5, 2019 at 5:51 PM Luís Marques wrote: > Hello, > > This patch mainly intends to add Clang/LLVM support, which currently is > broken. > > Problem: the const pointer trick (used by the struct globals, etc.) is > technically undefined behavior. In practice, it causes problems with > an

Re: [PATCH v2 3/3] mdev: add support to run as daemon

2019-06-03 Thread Denys Vlasenko
Applied, thanks On Tue, May 7, 2019 at 9:00 PM Jan Klötzke wrote: > > Adds the -d option to run mdev in daemon mode handling hotplug events > from the kernel like udev. If the system generates many hotplug events > this mode of operation will consume less resources than registering > mdev as

Re: [PATCH] losetup: Add partition scanning option

2019-05-30 Thread Denys Vlasenko
Applied, thanks On Tue, May 28, 2019 at 4:28 PM Jack O'Sullivan wrote: > > Add -P option from util-linux losetup to scan for partitions (for > kernels 3.2 and up). > > Signed-off-by: Jack O'Sullivan > --- > include/libbb.h | 1 + > util-linux/losetup.c | 27 +-- >

Re: [PATCH 1/1] [PATCH] udhcp: Fixed aliasing compilation error and alignment issues.

2019-05-26 Thread Denys Vlasenko
On Fri, May 24, 2019 at 12:51 PM Martin Lewis wrote: > Fixed the compilation warning: > networking/udhcp/d6_common.h:146:99: warning: dereferencing type-punned > pointer will break strict-aliasing rules [-Wstrict-aliasing] > #define client6_data (*(struct >

Re: [PATCH] - ls: fix SEGV when --color is used and ENABLE_LS_COLOR=n

2019-05-26 Thread Denys Vlasenko
Applied, thanks On Fri, May 24, 2019 at 3:58 PM Marco Oliverio wrote: > > Hi, > > Disable color long option at ls.c:1089 when ENABLE_LS_COLOR=n. > > Marco > ___ > busybox mailing list > busybox@busybox.net >

Re: libarchive: treat one "FIXME: avoid seek" patch issue

2019-05-26 Thread Denys Vlasenko
On Sun, May 26, 2019 at 12:48 AM Rostyslav Kurylo wrote: > > Hi everyone, > > I was playing around with the busybox master branch and found an > issue with the "libarchive: treat one "FIXME: avoid seek"" patch > (commit hash dff2bd733fc2dac08d34f2cfad0e68aeb8e7a7a2). > > The

Re: The DHCP-client in RENEWING state does not reply to broadcast messages

2019-05-26 Thread Denys Vlasenko
On Fri, May 24, 2019 at 2:09 PM Krzysztof Charusta wrote: > Hi, > > I am not saying that changing to LISTEN_RAW is acceptable/optimal solution. > > I think the question that needs answer is: > Should a client listen to broadcast messages while in the RENEWING state? > I didn't find in RFC2131 any

Re: The DHCP-client in RENEWING state does not reply to broadcast messages

2019-05-24 Thread Denys Vlasenko
CAST flag is for. RFC's generally specify which packets should/should not be broadcast, and BROADCAST flag is intended to be used when some hardware would fail to receive unicasts until fully configured. > > Brad Kemp > > On May 23, 2019, at 8:36 AM, Denys Vlasenko wrote: > > On T

Re: The DHCP-client in RENEWING state does not reply to broadcast messages

2019-05-23 Thread Denys Vlasenko
On Thu, May 23, 2019 at 9:30 AM Krzysztof Charusta wrote: > I upgraded busybox from version 1.29.2 to 1.30.1 and noticed that the client > behaves differently after commit "udhcpc: ensure at least one > unicast renew attempt" (c05aa6a776ab2420a42c041a3b5d45db587fd9ef). > > I'm testing a setup: >

Re: udhcpd: HOST_NAME support for static leases

2019-05-21 Thread Denys Vlasenko
On Mon, May 20, 2019 at 6:30 PM Philippe Jounin wrote: > > Hello Denys, > > Tested under a debian box: Works as expected with the configuration file > joined !! > Targets tried: debian, centOS, cisco routers > > A few very minor remarks: >- with high verbose level (3v), log_static_leases

Re: [PATCH] networking: cc is not a register

2019-05-17 Thread Denys Vlasenko
Applied, thanks! On Thu, Mar 7, 2019 at 6:06 AM Khem Raj wrote: > > gcc accepts > > __asm__ ( "" : : : "%cc"); > > but cc is not a real register and clang does not like it. > > networking/tls_pstm_montgomery_reduce.c:385:4: error: unknown register name > '%cc' in asm > |

Re: udhcpd: HOST_NAME support for static leases

2019-05-16 Thread Denys Vlasenko
Applied with a lot of changes. Please test current git! On Tue, May 7, 2019 at 11:18 PM Philippe Jounin wrote: > Hello all, > > First of all, thanks for the continuous support of busybox. I love this set > of small footprints applications. > > I made a quick hack for udhcpd to support

Re: dc's stack breaks when doing modulo-0

2019-05-16 Thread Denys Vlasenko
ok On Sat, May 11, 2019 at 2:47 AM Markus Gothe wrote: > > You're right; I did dig into this and it seems to be a (MIPS-)kernel issue > indeed. > > However I think it would be nice to fix this in busybox as well as we cannot > know if there is a buggy kernel or not because different

Re: [PATCH] hush: Check special names after export (ex. PS1)

2019-05-14 Thread Denys Vlasenko
On Mon, May 13, 2019 at 11:01 PM Catherine Garabedian wrote: > > Package: busybox > Version: v1.30.1 > Severity: medium > > This patch (attached) causes the special hush variables (PS1, PS2, LINENO, > etc) to be updated after an `export` command is performed. > > This fixes a bug where, when the

Re: [PATCH 1/1] Correct 'ln -T' usage message.

2019-05-09 Thread Denys Vlasenko
Applied, thanks On Thu, May 9, 2019 at 4:22 PM John L. Hammond wrote: > > Signed-off-by: John L. Hammond > --- > coreutils/ln.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/coreutils/ln.c b/coreutils/ln.c > index 3fe2f3f64..7feff53de 100644 > --- a/coreutils/ln.c >

Re: dc's stack breaks when doing modulo-0

2019-05-09 Thread Denys Vlasenko
On Wed, May 8, 2019 at 7:31 PM Markus Gothe wrote: > dc -e '4 0 % p' mess up the stack so bad that my MIPS kernel traps it and > reboots. $ strace ./busybox dc -e '4 0 % p' execve("./busybox", ["./busybox", "dc", "-e", "4 0 % p"], 0x7ffd62d779e8 /* 53 vars */) = 0 strace: [ Process PID=28924

Re: [PATCH 1/1] Optionally re-introduce bb_info_msg()

2019-04-30 Thread Denys Vlasenko
Applied, thanks! On Fri, Apr 12, 2019 at 7:02 PM James Byrne wrote: > > Between Busybox 1.24.2 and 1.25.0 the bb_info_msg() function was > eliminated and calls to it changed to be bb_error_msg(). The downside of > this is that daemons now log all messages to syslog at the LOG_ERR level > which

Re: [PATCH] - ifupdown.c: remove memory leak

2019-04-28 Thread Denys Vlasenko
Fixed in a bit different way. On Sun, Apr 28, 2019 at 5:09 PM Chloe Kudryavtsev wrote: > > This has been in the tree for a pretty long time, and usually > `if{up,down} -a` is a short-lived process. > > Generally speaking, no memory leak > memory leak (even in short lived > processes). > > The

Re: [PATCH 2/2] vi: enable 'dG' command. Closes 11801

2019-04-28 Thread Denys Vlasenko
Applied both, thanks! On Sun, Apr 28, 2019 at 10:10 AM Ron Yorston wrote: > > The 'G' command was omitted from the list of commands that change or > delete whole lines. Add it in the appropriate places so the 'dG', > 'cG' and 'yG' commands work, including in cases where an explicit > line

Re: [PATCH] start-stop-daemon: Fix -x is not required for -K

2019-04-27 Thread Denys Vlasenko
Applied, thanks On Fri, Apr 26, 2019 at 12:27 PM Alexander Vickberg wrote: > > Hi, > > Commit 088fec36fedff2cd50437c95b7fb430abf8d303c made -x required for > all. However it isn't for -K. > > Signed-off-by: Alexander Vickberg > > function old new

Re: bzcat/zcat does eat huge amounts of memory.

2019-04-20 Thread Denys Vlasenko
On Fri, Apr 19, 2019 at 4:23 PM Markus Gothe wrote: > > Seems to me that the implementation is seriously flawed, it decompress the > whole file into the heap and then print it out. Can't reproduce: $ ./busybox zcat 392mbyte_gzipped_file.gz >/dev/null & pid=$!; pmap $pid; while pmap $pid; do

Re: [PATCH v3 2/2] ash: catch error in arithmetic expansion in PS1

2019-04-19 Thread Denys Vlasenko
Applied, thanks! On Thu, Apr 18, 2019 at 2:16 PM Ron Yorston wrote: > > Setting PS1 to: > >PS1='$((123+))' > > causes the shell to enter an infinite error loop: > >sh: arithmetic syntax error > > Catch any exception raised by expandarg() in expandstr() and allow > processing to continue.

Re: [PATCH] dc.tests: fix two test case to also depend on DC_BIG

2019-04-19 Thread Denys Vlasenko
Applied, thanks On Wed, Apr 17, 2019 at 5:00 AM Chen Qi wrote: > > Signed-off-by: Chen Qi > --- > testsuite/dc.tests | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/testsuite/dc.tests b/testsuite/dc.tests > index 1708a48..8c3af41 100755 > --- a/testsuite/dc.tests

Re: [PATCH] httpd: Pass authorization header to CGI if not Basic

2019-04-18 Thread Denys Vlasenko
applied, thanks On Wed, Apr 17, 2019 at 10:10 AM Alexander Vickberg wrote: > > Hi, > > Pass the Authorization header to CGI if not of type Basic. This will > make it possible for CGI to verify authorization headers of type > Bearer . > > Signed-off-by: Alexander Vickberg > > function

Re: [PATCH] httpd: When sending gzipped content use content-length header

2019-04-17 Thread Denys Vlasenko
Applied, thanks On Wed, Apr 17, 2019 at 9:56 AM Alexander Vickberg wrote: > > Hi, > > Today for gzipped content httpd is using a header with name > Transfer-Length. However I can't find a header with that name in the > standards. Instead use Content-Length. > > Signed-off-by: Alexander Vickberg

Re: [PATCH v2 2/2] ash: add bash-compatible EPOCH variables

2019-04-16 Thread Denys Vlasenko
Applied all three patches. Thanks! On Mon, Apr 15, 2019 at 11:52 AM Ron Yorston wrote: > > Bash 5.0 added the dynamic variable EPOCHSECONDS and EPOCHREALTIME > which return the number of seconds since the Unix Epoch as an > integer or float. These are useful for logging or tracing. > > function

Re: [PATCH v4] httpd: Pass custom HTTP headers to CGI scripts

2019-04-16 Thread Denys Vlasenko
Applied with some edits. Please test current git. On Tue, Apr 16, 2019 at 8:41 AM Alexander Vickberg wrote: > > Sorry about this but apparently I can't configure Gmail to not ruin the email > formatting so I am attaching the diff instead. > > Also I wonder if you meant to do this in commit

Re: [PATCH v4] httpd: Pass custom HTTP headers to CGI scripts

2019-04-14 Thread Denys Vlasenko
On Tue, Apr 9, 2019 at 8:25 AM Alexander Vickberg wrote: > > This revision has changes from Xabier Onecas comments on v3. Please retain commit text which explains what this change does, and why. +typedef struct HTTP_Header { +struct HTTP_Header *next; +char *name; +char *value; +}

Re: [PATCH] ash: add bash-compatible EPOCH variables

2019-04-14 Thread Denys Vlasenko
On Tue, Apr 9, 2019 at 9:28 AM Ron Yorston wrote: > Bash 5.0 added the dynamic variable EPOCHSECONDS and EPOCHREALTIME > which return the number of seconds since the Unix Epoch as an > integer or float. These are useful for logging or tracing. Thanks! Can you add them to hush too? >

Re: [PATCH] examples/udhcp/simple.script: fix resolv.conf update if it is a dangling symlink

2019-04-13 Thread Denys Vlasenko
Applied, thanks On Thu, Mar 28, 2019 at 3:29 PM Rolf Eike Beer wrote: > > If /etc/resolv.conf is a symlink to a tmpfs and the actual file does not > already exist, "readlink -f" will not detect it as symlink. Explicitely check > for that condition before and touch the file, making the other code

Re: [PATCH] udhcp: add 100 and 101 dhcp options for ipv4

2019-04-13 Thread Denys Vlasenko
Applied, thanks On Fri, Mar 8, 2019 at 3:34 PM Antoine Girard-Vallée wrote: > > Support for the IEEE timezone string and timezone database strings (100 > and 101 options respectively) is added for ipv4, conforming to RFC-4833. > > The two options are passed to hook scripts in the variables tzstr

Re: [PATCH] stat: reduce storage for human-readable filesystem names

2019-04-12 Thread Denys Vlasenko
On Mon, Mar 18, 2019 at 12:15 PM Ron Yorston wrote: > >textdata bss dec hex filename > 93002841991888 936115 e48b3 busybox_old > 92975341991888 935840 e47a0 busybox_unstripped The difference is suspiciously large. > +# define FS_TYPE(type, name) type,

Re: [Bug 11751] New: chrt Segmentation fault

2019-04-05 Thread Denys Vlasenko
On Thu, Apr 4, 2019 at 5:48 PM wrote: > > https://bugs.busybox.net/show_bug.cgi?id=11751 > > Bug ID: 11751 >Summary: chrt Segmentation fault >Product: Busybox >Version: 1.29.x > Hardware: Other > OS: Linux >

Re: [PATCH] telnetd: Added support for AYT IAC command.

2019-04-04 Thread Denys Vlasenko
On Thu, Apr 4, 2019 at 1:33 PM Martin Lewis wrote: > > Fixed a TODO in AYT IAC handling by replying back with a NOP. > > Signed-off-by: Martin Lewis > --- > networking/telnetd.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/networking/telnetd.c

Re: [PATCH] top: provide cmdline argument '-H' to enable thread scanning by default

2019-04-04 Thread Denys Vlasenko
Applied, thanks! On Tue, Mar 26, 2019 at 1:09 PM Thomas De Schampheleire wrote: > > From: Thomas De Schampheleire > > In particular useful when you want to evaluate the threads in batch mode: > top -Hbn1 > > Signed-off-by: Philippe Belet > Signed-off-by: Thomas De Schampheleire > --- >

Re: [PATCH] vi: avoid build failure in non-default case

2019-04-03 Thread Denys Vlasenko
Applied, thanks On Wed, Apr 3, 2019 at 9:56 AM Ron Yorston wrote: > > If vi is built with FEATURE_VI_USE_SIGNALS disabled and > FEATURE_VI_WIN_RESIZE enabled new_screen() is used without a > declaration. Move the function to avoid this. > > Signed-off-by: Ron Yorston > --- > editors/vi.c | 32

Re: sed in-place write unsafe (was: Power-fail safe writes)

2019-04-03 Thread Denys Vlasenko
On Wed, Apr 3, 2019 at 12:07 PM Cristian Ionescu-Idbohrn wrote: > > Denys, > > On Tue, 2 Apr 2019, Sebastian Brand wrote: > > > > I recently had problems when updating a configuration file using sed > > with in-place edit option (-i), shortly followed by a power fail, > > which has the end result

Re: Power-fail safe writes

2019-04-02 Thread Denys Vlasenko
On Tue, Apr 2, 2019 at 11:55 AM Cristian Ionescu-Idbohrn wrote: > > On Tue, 2 Apr 2019, Sebastian Brand wrote: > > > > I recently had problems when updating a configuration file using sed > > with in-place edit option (-i), shortly followed by a power fail, > > which has the end result of an

Re: [PATCH] ash: distinguish 'wait -n' from other bashisms

2019-04-02 Thread Denys Vlasenko
Applied, thanks! On Sun, Mar 31, 2019 at 10:27 AM Ron Yorston wrote: > > Add a specific define to indicate which bash compatibility code > implements 'wait -n'. > > Signed-off-by: Ron Yorston > --- > shell/ash.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff

Re: Embedded script 'nologin' breaks individual binaries

2019-04-01 Thread Denys Vlasenko
Can't reproduce. Fixed in git? On Fri, Mar 29, 2019 at 10:46 PM Yann E. MORIN wrote: > > Hello All, > > The 'nologin' embedded script breaks the build when individual binaries > is enabled. The attached minimalist config exhibits the issue: > > Trying libraries: crypt m > Library crypt is not

Re: [PATCH] ip: Fix ip -o link

2019-03-30 Thread Denys Vlasenko
Applied, thanks! On Wed, Mar 27, 2019 at 5:15 PM Sørensen, Stefan wrote: > > Commit db169f253854db572c0c2b7e3d74ebbe6afdb97f breaks the "ip -o link" > command, no output is displayed.. Fix by only excluding the link info if > in oneline mode and if the address family is not AF_PACKET. > >

Re: [PATCH] vi: allow manual screen update if SIGWINCH isn't supported

2019-03-30 Thread Denys Vlasenko
Applied, thanks. On Wed, Mar 20, 2019 at 12:00 PM Ron Yorston wrote: > > On platforms that don't support SIGWINCH vi can be configured > with FEATURE_VI_USE_SIGNALS disabled and FEATURE_VI_WIN_RESIZE > enabled. This allows the user to force an update with ^L when > the screen is resized. > >

Re: Default location for man pages

2019-03-30 Thread Denys Vlasenko
Done, please test. On Fri, Mar 22, 2019 at 9:34 AM Ron Yorston wrote: > > The man applet in BusyBox sets /usr/man as the default place to > look for man pages if no other configuration is provided. Many > systems these days put man pages in /usr/share/man. > > Should we have /usr/share/man as a

Re: [PATCH] libbb: mark scripted_main() as externally visible

2019-03-30 Thread Denys Vlasenko
Applied, thanks! On Sat, Mar 30, 2019 at 8:47 AM Ron Yorston wrote: > > Building with individual binaries enabled fails when embedded > script applets are included: > >/tmp/ccIvMFZg.o: In function `main': >applet.c:(.text.main+0x20): undefined reference to `scripted_main' > > Mark

Re: ntpd pidfile

2019-03-27 Thread Denys Vlasenko
On Tue, Mar 19, 2019 at 6:44 PM Alfonso Ranieri wrote: > > Is there any reason to create the pidfile for ntpd even if with the -n > option? > > It may happen that busybox ntpd is run just to set or test the time with > a server, while another ntpd is running with its pid file. > > I usually use

Re: [PATCH v2] man: don't skip default path which appears in config file

2019-03-26 Thread Denys Vlasenko
Applied, thanks! On Fri, Mar 22, 2019 at 5:25 PM Ron Yorston wrote: > > If the MANPATH environment variable isn't set a provisional default > path of /usr/man is placed in man_path_list. This is only used if a > configuration file doesn't contain an alternative path. > > If a configuration file

Re: [git commit] do not duplicate CONFIG_PID_FILE_PATH and ".pid" strings

2019-03-18 Thread Denys Vlasenko
On Mon, Mar 18, 2019 at 8:54 AM Bernhard Reutner-Fischer wrote: > On 17 March 2019 19:48:39 CET, Denys Vlasenko > wrote: > >commit: > >https://git.busybox.net/busybox/commit/?id=5059653882dbd86e3bbf48389f9f81b0fac8cd0a > >branch: https://git.busybox.net/busybox/comm

Re: bb_daemonize_or_rexec(DAEMON_CLOSE_EXTRA_FDS) does not close extra fds

2019-03-15 Thread Denys Vlasenko
On Thu, Mar 14, 2019 at 4:35 PM Arnout Vandecappelle wrote: > I've noticed that bb_daemonize_or_rexec(DAEMON_CLOSE_EXTRA_FDS + > DAEMON_DEVNULL_STDIO) does not actually close all fds. This is what gets > called > by start-stop-daemon -b, so it means that start-stop-daemon will propagate all >

Re: volume_id: off by one error detecting FAT16 vs FAT32

2019-03-15 Thread Denys Vlasenko
Applied, thanks! On Thu, Mar 14, 2019 at 5:38 PM Thomas Frauendorfer wrote: > > Hello, > > Busybox detects a FAT file system with 65524 clusters as FAT32 while > it should handle it as FAT16. Because of that blkid cannot detect the > uuid or label on a FAT with 65524 clusters. > > The attached

Re: [PATCH] scripts/echo.c: resolve implicit declaration of function 'dup2'

2019-03-05 Thread Denys Vlasenko
Applied, thanks! On Tue, Mar 5, 2019 at 12:01 PM Nicolas Hüppelshäuser wrote: > > Signed-off-by: Nicolas Hüppelshäuser > --- > scripts/echo.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/echo.c b/scripts/echo.c > index 8c6b409d3..7474ccdd4 100644 > --- a/scripts/echo.c >

Re: [PATCH 1/1] udhcpc: don't exit after backgrounding on -n -b

2019-02-26 Thread Denys Vlasenko
Applied, thanks On Tue, Feb 26, 2019 at 6:41 PM Andrey wrote: > > > 26.02.2019, 11:20, "Denys Vlasenko" : > > On Fri, Feb 22, 2019 at 10:46 PM wrote: > >> From: Andrey Mazo > >> > >> Currently, running "udhcpc -n -b" causes

Re: [PATCH 1/1] udhcpc: don't exit after backgrounding on -n -b

2019-02-26 Thread Denys Vlasenko
On Fri, Feb 22, 2019 at 10:46 PM wrote: > > From: Andrey Mazo > > Currently, running "udhcpc -n -b" causes udhcpc to go to background and > then exit after some time unless a lease is obtained. > > It's not very useful to do so > as the calling process doesn't know > if the lease was obtained or

Re: [PATCH] ash: avoid leaking memory associated with redirections. Closes 7748

2019-02-25 Thread Denys Vlasenko
Applied, thanks! On Mon, Feb 25, 2019 at 9:29 AM Ron Yorston wrote: > > The following constructs result in ever-increasing memory usage: > >while true; do { true; } while true; do ( true; ) > For comparison, bash displays static memory usage in both cases. > > This has been fixed in

Re: [PATCH] du: don't count duplicate arguments. Closes 5288

2019-02-19 Thread Denys Vlasenko
Applied, thanks! On Sat, Feb 16, 2019 at 11:22 AM Ron Yorston wrote: > > Since coreutils 8.6 (2010-10-15) du no longer counts duplicate arguments. > > Revert the relevant part of commit 618a3027ed (du: fix "du /dir /dir" > case). > > function old

Re: Runit Fatal Error: Function Not Implemented

2019-02-19 Thread Denys Vlasenko
On Sat, Feb 16, 2019 at 7:29 AM Richardyusen wrote: > Hello, > Sorry, I typed the error message from my memory. I ran it again and the exact > message did use the word "can't" instead of "unable to". I lost my previous > busybox build config, so I rebuilt a new one following the same procedure I

Re: [PATCH] dd: add 'oflag=append'

2019-02-14 Thread Denys Vlasenko
Applied, thanks! On Wed, Feb 6, 2019 at 1:16 PM Rostislav Skudnov wrote: > > Signed-off-by: Rostislav Skudnov > --- > coreutils/dd.c | 16 ++-- > docs/posix_conformance.txt | 1 + > 2 files changed, 11 insertions(+), 6 deletions(-) > > diff --git a/coreutils/dd.c

Re: ash builtin function `read' called without arguments...

2019-02-11 Thread Denys Vlasenko
On Sat, Feb 9, 2019 at 5:10 PM Cristian Ionescu-Idbohrn wrote: > > On Sat, 9 Feb 2019, Denys Vlasenko wrote: > > On Wed, Jan 30, 2019 at 2:09 PM Cristian Ionescu-Idbohrn > > wrote: > > > ...sets implicit variable REPLY, even though ASH_B

Re: [PATCH] vi: further fixes to undo after autoindent

2019-02-11 Thread Denys Vlasenko
Applied, thanks! On Mon, Feb 11, 2019 at 9:29 AM Ron Yorston wrote: > > Commit bb983f30e (vi: fix faulty undo after autoinsert) has a > number of problems: > > - The commit message refers to 'autoinsert' when it really means > 'autoindent'. > > - The indentation of undo_push_insert() was

Re: [PATCH v3] i2c_tools.c: add i2ctransfer utility

2019-02-10 Thread Denys Vlasenko
On Sun, Feb 10, 2019 at 7:24 PM Denys Vlasenko wrote: > On Mon, Jan 7, 2019 at 2:29 PM Nikolaus Voss wrote: > > i2ctransfer sends and receives user defined i2c messages > > v2: apply Xabier's comments: add -a option, don't decrement argc, > > use bb_show_usage() and

Re: [PATCH v3] i2c_tools.c: add i2ctransfer utility

2019-02-10 Thread Denys Vlasenko
On Mon, Jan 7, 2019 at 2:29 PM Nikolaus Voss wrote: > i2ctransfer sends and receives user defined i2c messages > > v2: apply Xabier's comments: add -a option, don't decrement argc, > use bb_show_usage() and xzalloc() > v3: fix possible out of bound access to msgs[nmsgs] > > Reviewed-by:

Re: logging with pam to busybox

2019-02-09 Thread Denys Vlasenko
‪On Sun, Jan 20, 2019 at 6:48 PM ‫אלכסיי סיליוק‬‎ wrote:‬ > > Hello, i am using busybox to run on my embedded device. > i am using tacacs server to authenticate to device instead of using local > database and i faced some problem. > i am removing username "su" from /etc/passwd .after that i am

Re: ash builtin function `read' called without arguments...

2019-02-09 Thread Denys Vlasenko
On Wed, Jan 30, 2019 at 2:09 PM Cristian Ionescu-Idbohrn wrote: > ...sets implicit variable REPLY, even though ASH_BASH_COMPAT is not > set. > > That was introduced in 2010-01-12 with commit > 045f4ad92c07434625e168bc8c37aa0e89f6e58e. The comment is still > present in the code: > > +

Re: [PATCH v2] sysctl: fix compatibility with procps sysctl

2019-02-08 Thread Denys Vlasenko
Applied in a slightly different form. Please test current git. On Mon, Feb 4, 2019 at 8:38 PM Aaro Koskinen wrote: > > From: Aaro Koskinen > > Busybox sysctl is incompatible with procps when '.' appears in > directory name, mostly happens with VLANs. > > busybox syntax (since 2008):

Re: [PATCH] vi: fix replacement of single character with CR

2019-02-08 Thread Denys Vlasenko
Applied, thanks! On Sun, Feb 3, 2019 at 3:02 PM Ron Yorston wrote: > > Currently if the 'r' command is followed by a carriage return a > literal CR replaces the current character. > > Fix this so that: > > - a new line is inserted > - the autoindent setting is respected > - the cursor is placed

Re: [PATCH] vi: fix faulty undo after autoinsert

2019-02-08 Thread Denys Vlasenko
Applied, thanks! On Sun, Feb 3, 2019 at 11:13 AM Ron Yorston wrote: > > Enable autoinsert and enter the following with an indent of three > spaces: > >line 1 >line 2 > > Using 'u' to undo the last insert results in: > >line1e 2 > > The insertion of the indent hasn't been properly

Re: [PATCH] chcon: Fix typo in ACTION_RECURSE

2019-02-08 Thread Denys Vlasenko
Applied, thanks On Wed, Feb 6, 2019 at 1:16 PM Rostislav Skudnov wrote: > > Signed-off-by: Rostislav Skudnov > --- > selinux/chcon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/selinux/chcon.c b/selinux/chcon.c > index 92eb767..5bf9171 100644 > ---

Re: loginutils, login prompt

2019-01-29 Thread Denys Vlasenko
‪On Mon, Jan 28, 2019 at 10:36 AM ‫אלכסיי סיליוק‬‎ wrote:‬ > > hello, I am using loginutils, and I see that > at login prompt if I entering username incorrect and want to remove part of > username, I cant to edit it, in code I see you using getting username char by > char, I want to get name

Re: [PATCH v2 2/2] findutils/grep.c: Short-circuit -v to bail out on first match

2019-01-29 Thread Denys Vlasenko
I'm going with this: - /* If it's non-inverted search, we can stop -* at first match */ - if (found && !invert_search) - goto do_found; + /* If it's a non-inverted search, we

Re: [PATCH] ash: add process substitution in bash-compatibility mode

2019-01-29 Thread Denys Vlasenko
On Mon, Jan 28, 2019 at 10:16 AM Ron Yorston wrote: > Denys wrote: > >Can we use popredir() mechanism instead? > > It's possible but it adds more complication to already complex code. > Currently the stack of redir fds is always unwound unconditionally. > The procsub fds are conditionally removed

Re: [PATCH] ash: add process substitution in bash-compatibility mode

2019-01-24 Thread Denys Vlasenko
On Fri, Nov 23, 2018 at 2:10 PM Ron Yorston wrote: > > Process substitution is a Korn shell feature that's also available > in bash and some other shells. This patch implements process > substitution in ash when ASH_BASH_COMPAT is enabled. > +#if BASH_PROCESS_SUBST > + /* If we don't

Re: closing session in case of pam auth failed

2019-01-22 Thread Denys Vlasenko
Applied, thanks ‪On Tue, Jan 22, 2019 at 8:04 AM ‫אלכסיי סיליוק‬‎ wrote:‬ > > Hello, i faced that if PAM and CHILD_PROCCESS for login enabled, in case of > authorithation failure, session not closed. > i am added next to my code, may be it will be usable for somebody in future. > i added

Re: closing session in case of pam auth failed

2019-01-22 Thread Denys Vlasenko
‪On Tue, Jan 22, 2019 at 8:04 AM ‫אלכסיי סיליוק‬‎ wrote:‬ > > Hello, i faced that if PAM and CHILD_PROCCESS for login enabled, in case of > authorithation failure, session not closed. > i am added next to my code, may be it will be usable for somebody in future. > i added

Re: Issue/bug with wget over https and proxy

2019-01-21 Thread Denys Vlasenko
On Mon, Jan 21, 2019 at 2:53 PM Jakub Ledwoń wrote: > I have env variables set up like this: > http_proxy=http://proxy_ip:8080 > https_proxy=http://proxy_ip:8080 > ftp_proxy=http://proxy_ip:8080 > When I'm trying to use wget on https link behind this proxy, it fails. On > http links it works

Re: [PATCH] sed: Fix backslash parsing for 'w' command arg

2019-01-21 Thread Denys Vlasenko
Applied, thanks! On Wed, Jan 2, 2019 at 10:10 PM Brian Foley wrote: > > If there's any whitespace between w and the filename, parse_file_cmd > writes to the wrong offset when trying to fix up backslashes. > > This can be seen in the asan build with busybox sed -e 'w 0\\' > > Signed-off-by: Brian

Re: [PATCH] awk: Fix overly permissive func arg list parsing

2019-01-21 Thread Denys Vlasenko
Applied all three patches, thanks! > +testing "awk func arg parsing 1" \ > + "awk 'func f(,) { }' 2>&1" "awk: cmd. line:1: Unexpected token" "" "" Should be "awk: cmd. line:1: Unexpected token\n" -- with \n ___ busybox mailing list

Re: [PATCH] capability: Fix string comparison in cap_name_to_number

2019-01-21 Thread Denys Vlasenko
Applied, thanks! On Fri, Jan 18, 2019 at 9:22 AM Mark Marshall wrote: > > Hi. > > > The attached patch fixes a bug in libbb/capability.c. > > The result of strcasecmp was being used wrongly. > > > This bug was introduced by change > > 44b3f2ffbc01c0a9fcfb5d60af3e292f505ac67c > > > Regards, > >

Re: [PATCH 1/2] wget: replace set_alarm with non blocking functions to support retries

2019-01-20 Thread Denys Vlasenko
Throws a warning: networking/wget.c: In function 'fread_buffered': networking/wget.c:575: error: declaration of 'read' shadows a global declaration Way too large, and adds to bss: function old new delta fgets_buffer

Re: [PATCH 1/1] wget: don't notify on download begin and end if quiet

2019-01-17 Thread Denys Vlasenko
Applied, thanks On Thu, Jan 10, 2019 at 1:59 PM Martin Lewis wrote: > > When printing notification on download start and end, > mistakenly, it didn't respect the quiet option > > Signed-off-by: Martin Lewis > --- > networking/wget.c | 23 ++- > 1 file changed, 14

Re: Busybox: prevent compile hang and it gets stuck in a loop.

2019-01-16 Thread Denys Vlasenko
yes '' | make oldconfig ? On Tue, Jan 15, 2019 at 8:13 AM Md Sikandar wrote: > > I upgrading the busybox in my openwrt sdk.. > The BZIP2_SMALL option was not being exposed via Config.in which caused the > build to fail as 'yes' is piped to the config during > build. As it's expecting a

Re: nslookup incorrect exit code

2019-01-09 Thread Denys Vlasenko
Fixed in git, thanks On Wed, Jan 9, 2019 at 12:01 PM Slava Bacherikov wrote: > > Hi, > > It looks like busybox recently changed behavior of nslookup and this > broke some scripts. Previously, nslookup returned 1 as exit code if DNS > server returned NXDOMAIN, or some other failure. Actually,

<    1   2   3   4   5   6   7   8   9   10   >