3151e9a923835da9
On Tue, Jan 23, 2018 at 2:42 PM, Denys Vlasenko
wrote:
> On Tue, Jan 23, 2018 at 12:18 AM, Eugene Rudoy wrote:
>> Unfortunately it is not possible in C to check for the existence of an enum
>> value at compile-time. Implement an alternative "kernel version ch
elsewhere in busybox,
e.g. in ecce3a1999f3c5ded4baebbc0b17c48d80fe2781
Signed-off-by: Eugene Rudoy
---
miscutils/nandwrite.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/miscutils/nandwrite.c b/miscutils/nandwrite.c
index 29c800612..bfa4ea478 100644
--- a
Hi Denys,
On Thu, Nov 9, 2017 at 1:30 PM, Denys Vlasenko wrote:
> I'm wary of adding incompatible extensions.
That's the reason I made it optional. It's a quite straightforward
change and I was hoping it could be possible to maintain it upstream.
If no I'm perfectly fine with maintaining the chan
Signed-off-by: Eugene Rudoy
---
archival/unzip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/archival/unzip.c b/archival/unzip.c
index 83bd00c4e..50205eb6e 100644
--- a/archival/unzip.c
+++ b/archival/unzip.c
@@ -56,7 +56,7 @@
//kbuild:lib-$(CONFIG_UNZIP) += unzip.o
176/0) Total: 176 bytes
Signed-off-by: Eugene Rudoy
---
archival/unzip.c | 56 ++--
1 file changed, 54 insertions(+), 2 deletions(-)
diff --git a/archival/unzip.c b/archival/unzip.c
index 50205eb6e..d5a601a24 100644
--- a/archival/unzip.c
+++ b/arc
515cf strips path
components a little bit too early resulting in behavior
deviations.
Fix it by doing stripping after listing/filtering.
p.s. Info-ZIP's unzip behavior is the same as
that of tar in --strip-components=NUM mode
Signed-off-by: Eugene Rudoy
---
archival/unzip.c | 15
Hi Waldemar,
On Sat, Oct 28, 2017 at 10:16 AM, Waldemar Brodkorb wrote:
> May be somebody can suggest a patch to fix the bug in uClibc?
> I am always open for bugfixes.
I'll do in a couple of days (after the long weekend here in Germany).
Cheers,
Gene
Hi all,
just wanted to point out that besides making the code more portable
the change suggested by James has another positive side effect. It
eliminates the need for the uClibc related and as of now unreliable
workaround added in the second hunk of e184a88 [1].
Why unreliable? "statfs s"-variabl
rted only once for each
function it appears in
Fix it by using close_on_exec_on function provided by libbb
instead of passing O_CLOEXEC flag to open.
Signed-off-by: Eugene Rudoy
---
v2: remove unnecessary "if (output_fd >= 0)", xopen guarantees the returned
file descriptor to
e for
each function it appears in
iproute.c: In function 'iproute_modify':
iproute.c:467:36: error: 'RTA_TABLE' undeclared (first use in this function)
Fix it by partially #ifdef'ing the code added in
b42107f21538e39d9a344376372f8261aed589b2
Signed-off-by: Eugene Rudoy
-
Hi Ralf,
On Wed, Oct 18, 2017 at 12:31 PM, Ralf Friedl wrote:
> What is the purpose of O_CLOEXEC here? In both cases, we try to open a file.
> If the file is opened, we use the finit_module syscall and immediately close
> the file. Is there a danger that finit_module might exec something and the
Hi Walter,
On Wed, Oct 18, 2017 at 6:27 PM, walter harms wrote:
> while you are there ...
> please be more verbose "Do not use O_CLOEXEC flags" is nice but why ?
hmm, as the subject line states the change fixes the *build* problems
with *kernel* versions < 2.6.23, e.g.
miscutils/time.c: In funct
Hi Xabier,
On Wed, Oct 18, 2017 at 8:52 AM, Xabier Oneca -- xOneca
wrote:
>
> Doesn't xopen always guarantee output_fd will be valid? If so, there's
> no need for this 'if'.
you're right, s. [1]. Didn't know that before, thanks for pointing it
out. v2 of the patch will follow.
Cheers,
Gene
[1]
Do not use O_CLOEXEC flags (available since 2.6.23),
use close_on_exec_on provided by libbb instead (like everywhere else)
Signed-off-by: Eugene Rudoy
---
miscutils/time.c | 6 --
modutils/modprobe-small.c | 3 ++-
modutils/modutils.c | 3 ++-
3 files changed, 8 insertions
broken in b42107f21538e39d9a344376372f8261aed589b2
Signed-off-by: Eugene Rudoy
---
networking/libiproute/iproute.c | 9 +
networking/libiproute/iprule.c | 12 +++-
2 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/networking/libiproute/iproute.c b/networking
What about "mktemp --tmpdir tmp.XX"?
@Andrew: could you please test it under OS X? Don't have any here.
On Sun, Jul 10, 2016 at 8:10 PM, Denys Vlasenko
wrote:
> On Thu, Jul 7, 2016 at 4:09 AM, wrote:
>> From: Andrew Oates
>>
>> On OS X, mktemp can't be run without any arguments (it re
Hi Matt,
this is because of 28dd64a0e1a9cffcde7799f2849b66c0e16bb9cc [1].
As has been pointed out in [2] at least the following two commits need
to be merged to 1_22_stable: b664f740d90880560ce46b11f766625341342e80
[3] and 640ce3de07807133796bccd0bdfa146bbfc788c7 [4].
With 1_22_stable in its cur
Hi Bastian,
On Mon, Apr 27, 2015 at 8:47 AM, Bastian Bittorf wrote:
> Thanks for that - i did'nt know this till yet,
> and cannot find anything about 'local -' in the net,
> do you have a link?
the wording in the FreeBSD version of "man sh" is the most clear one (s. [1]):
The only special
follow-up of 0a0acb55db8d7c4dec445573f1b0528d126b9e1f
not sure if the code is worth adding it to the repository, multiple 'local -'s
are very very unlikely
Signed-off-by: Eugene Rudoy
---
shell/ash.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/shell/ash
ll be addressed in a separate commit.
Signed-off-by: Eugene Rudoy
---
shell/ash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/shell/ash.c b/shell/ash.c
index c51fb80..3e9997b 100644
--- a/shell/ash.c
+++ b/shell/ash.c
@@ -8979,7 +8979,7 @@ mklocal(char *name)
*/
Hi,
@Bastian: see 109ee5d336, your example is however quite strange -
what's the reason for declaring the variable twice, what's the real
use-case?
@Denys: your commit-message states "bash does that". bash indeed does
so for the test-case from your commit, but doesn't do so for Bastians
example (
Hi John,
On Mon, Nov 17, 2014 at 6:01 PM, John Spencer
wrote:
> Denys Vlasenko wrote:
>>
>> Already fixed in git
>
>
> thanks! it seems i should start considering an update of busybox.
> do you plan to do a release (candidate) in the next weeks ?
> seems the latest stable is nearly a year old alr
Hi Denys,
just wanted to point out that the patch currently available under
http://busybox.net/downloads/fixes-1.22.1/busybox-1.22.1-ash.patch is
not the SHLVL related one but some other one (it seems it's
2de232da53da6a79880defc5693242383af58764).
Best,
Gene
On Mon, Jan 20, 2014 at 2:01 PM, Den
/libiproute/iplink.c:453:35: error: 'IFLA_INFO_DATA' undeclared
(first use in this function)
make[2]: *** [networking/libiproute/iplink.o] Error 1
Signed-off-by: Eugene Rudoy
---
networking/libiproute/iplink.c | 12
1 file changed, 12 insertions(+)
diff --git a/networki
24 matches
Mail list logo
