Re: [PATCH] ash: only catch unexpected exceptions in PS1 expansion

2019-10-21 Thread Peter Korsgaard
> "Denys" == Denys Vlasenko writes: > On Sun, Oct 20, 2019 at 12:13 PM Bastian Bittorf wrote: >> >> On Sun, Oct 20, 2019 at 09:54:01AM +0100, Ron Yorston wrote: >> > Bastian Bittorf wrote: >> > >Maybe i am a "victim" of this patch: >> > >> > 1.30.0 has the faulty commit d1a2fa2a4

Re: [PATCH] ash: only catch unexpected exceptions in PS1 expansion

2019-10-21 Thread Denys Vlasenko
On Sun, Oct 20, 2019 at 12:13 PM Bastian Bittorf wrote: > > On Sun, Oct 20, 2019 at 09:54:01AM +0100, Ron Yorston wrote: > > Bastian Bittorf wrote: > > >Maybe i am a "victim" of this patch: > > > > 1.30.0 has the faulty commit d1a2fa2a4 (ash: catch error in arithmetic > > expansion in PS1) but

Re: [PATCH] ash: only catch unexpected exceptions in PS1 expansion

2019-10-20 Thread Bastian Bittorf
On Sun, Oct 20, 2019 at 09:54:01AM +0100, Ron Yorston wrote: > Bastian Bittorf wrote: > >Maybe i am a "victim" of this patch: > > 1.30.0 has the faulty commit d1a2fa2a4 (ash: catch error in arithmetic > expansion in PS1) but not the subsequent correction in commit 943e81f5d > (ash: only catch

Re: [PATCH] ash: only catch unexpected exceptions in PS1 expansion

2019-10-20 Thread Ron Yorston
Bastian Bittorf wrote: >Maybe i am a "victim" of this patch: 1.30.0 has the faulty commit d1a2fa2a4 (ash: catch error in arithmetic expansion in PS1) but not the subsequent correction in commit 943e81f5d (ash: only catch unexpected exceptions in PS1 expansion). Commit 943e81f5d should be

Re: [PATCH] ash: only catch unexpected exceptions in PS1 expansion

2019-10-19 Thread Bastian Bittorf
On Wed, Jul 31, 2019 at 01:45:23PM +0200, Denys Vlasenko wrote: > Applied, thanks! > > On Mon, Jul 29, 2019 at 11:00 AM Ron Yorston wrote: > > > > Commit d1a2fa2a4 (ash: catch error in arithmetic expansion in PS1) > > catches all exceptions raised by expandarg(). Some exceptions, such as > >

Re: [PATCH] ash: only catch unexpected exceptions in PS1 expansion

2019-07-31 Thread Denys Vlasenko
Applied, thanks! On Mon, Jul 29, 2019 at 11:00 AM Ron Yorston wrote: > > Commit d1a2fa2a4 (ash: catch error in arithmetic expansion in PS1) > catches all exceptions raised by expandarg(). Some exceptions, such as > the EXEXIT raised when command expansion is used, are expected: > >export

[PATCH] ash: only catch unexpected exceptions in PS1 expansion

2019-07-29 Thread Ron Yorston
Commit d1a2fa2a4 (ash: catch error in arithmetic expansion in PS1) catches all exceptions raised by expandarg(). Some exceptions, such as the EXEXIT raised when command expansion is used, are expected: export PS1='$(echo "$ ")' These should be processed normally or the shell hangs at the