On Thu, 11 Jun 2020 13:12:53 -0500
Martin Lewis wrote:
> Hi,
> Yes, looks good :)
PS: i was at first a bit thrown off by the function name to talk about
DNAME RR (as opposed to CNAME RR resp. domain_name) but in the context
of dhcp as opposed to dns it makes more sense i suppose. I'd expand the
Hi,
Yes, looks good :)
Martin
On Wed, 10 Jun 2020 at 10:21, Denys Vlasenko
wrote:
> Thanks. I addressed this a bit differently. Looks good now?
>
> On Tue, Jun 9, 2020 at 4:55 PM Martin Lewis
> wrote:
> >
> > The only call to dname_enc is with cstr = NULL, so most of dname_enc's
> logic is not
Thanks. I addressed this a bit differently. Looks good now?
On Tue, Jun 9, 2020 at 4:55 PM Martin Lewis wrote:
>
> The only call to dname_enc is with cstr = NULL, so most of dname_enc's logic
> is not used.
> Therefore, we can directly call convert_dname and shrink the binary size.
>
> function
The only call to dname_enc is with cstr = NULL, so most of dname_enc's logic is
not used.
Therefore, we can directly call convert_dname and shrink the binary size.
function old new delta
convert_dname -
